Commit 8dfc2b05 by Jamie Madill Committed by Commit Bot

Update codegen presubmit error.

Clarifies that gclient sync should happen before codegen to avoid using stale hashes on upload. Bug: angleproject:3227 Change-Id: I7777458b6fa659a07307ad1d845ac7d332afa8f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934313Reviewed-by: 's avatarEthan Lee <flibitijibibo@gmail.com> Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent e5b474c6
...@@ -53,11 +53,11 @@ def _CheckCodeGeneration(input_api, output_api): ...@@ -53,11 +53,11 @@ def _CheckCodeGeneration(input_api, output_api):
def __init__(self, message): def __init__(self, message):
super(output_api.PresubmitError, self).__init__( super(output_api.PresubmitError, self).__init__(
message, message,
long_text='Please run scripts/run_code_generation.py to refresh generated hashes.\n' long_text='Please ensure your ANGLE repositiory is synced to tip-of-tree\n'
'\n'
'If that fails, ensure your ANGLE repositiory is synced to tip-of-tree\n'
'and all ANGLE DEPS are fully up-to-date by running gclient sync.\n' 'and all ANGLE DEPS are fully up-to-date by running gclient sync.\n'
'\n' '\n'
'If that fails, run scripts/run_code_generation.py to refresh generated hashes.\n'
'\n'
'If you are building ANGLE inside Chromium you must bootstrap ANGLE\n' 'If you are building ANGLE inside Chromium you must bootstrap ANGLE\n'
'before gclient sync. See the DevSetup documentation for more details.\n') 'before gclient sync. See the DevSetup documentation for more details.\n')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment