Always enable NPOT for Vulkan backend

Vulkan natively supports non power-of-two textures so indicate that support for front-end. Bug: angle-project:3239 Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_texture_completeness_2d_npot_t_repeat --use-angle=vulkan Change-Id: Id9058b6e9afd1d43e5d74612f808ce39beafd35f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1561963 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Always enable NPOT for Vulkan backend
8f0210f7 · Courtney Goeltzenleuchter · Commit Bot · 1e064014 · 8f0210f7 · 8f0210f7
Commit 8f0210f7 authored Apr 10, 2019 by Courtney Goeltzenleuchter Committed by Commit Bot Apr 12, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

vk_caps_utils.cpp src/libANGLE/renderer/vulkan/vk_caps_utils.cpp +3 -0

deqp_gles2_test_expectations.txt src/tests/deqp_support/deqp_gles2_test_expectations.txt +0 -6

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
@@ -94,6 +94,9 @@ void RendererVk::ensureCapsInitialized() const
            ? mPhysicalDeviceProperties.limits.maxSamplerAnisotropy
            : 0.0f;

+    // Vulkan natively supports non power-of-two textures
+    mNativeExtensions.textureNPOT = true;
+
    // TODO(lucferron): Eventually remove everything above this line in this function as the caps
    // get implemented.
    // https://vulkan.lunarg.com/doc/view/1.0.30.0/linux/vkspec.chunked/ch31s02.html

--- a/src/tests/deqp_support/deqp_gles2_test_expectations.txt
+++ b/src/tests/deqp_support/deqp_gles2_test_expectations.txt
@@ -285,12 +285,6 @@
 3254 VULKAN NVIDIA : dEQP-GLES2.functional.clipping.point.point_clip_viewport_center = FAIL
 3254 VULKAN NVIDIA : dEQP-GLES2.functional.clipping.point.point_clip_viewport_corner = FAIL

-// Completeness failures
-3239 VULKAN : dEQP-GLES2.functional.texture.completeness.2d.npot_size = FAIL
-3239 VULKAN : dEQP-GLES2.functional.texture.completeness.2d.npot_size_level_1 = FAIL
-3239 VULKAN : dEQP-GLES2.functional.texture.completeness.cube.npot_size_level_1 = FAIL
-3239 VULKAN : dEQP-GLES2.functional.texture.completeness.cube.npot_size_level_1_neg_x = FAIL
-
 // These seem to fail on both D3D11 and Vulkan
 3243 VULKAN : dEQP-GLES2.functional.texture.mipmap.cube.basic.linear_nearest = FAIL
 3243 VULKAN : dEQP-GLES2.functional.texture.mipmap.cube.basic.linear_linear = FAIL