Commit 90f9ddd9 by Gert Wollny Committed by Angle LUCI CQ

Capture: Add support for capturing (Get)ClipPlanef equation

In addition, correctly handle "const GLfloat *" when replaying, and enable the according capture/replay tests Bug: angleproject:6047 Change-Id: I5dd7510d1b621d4c941490c9d0261559a96dd681 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2951133 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com>
parent 4375d6c7
...@@ -5412,6 +5412,22 @@ void WriteParamValueReplay<ParamType::TvoidConstPointer>(std::ostream &os, ...@@ -5412,6 +5412,22 @@ void WriteParamValueReplay<ParamType::TvoidConstPointer>(std::ostream &os,
} }
template <> template <>
void WriteParamValueReplay<ParamType::TGLfloatConstPointer>(std::ostream &os,
const CallCapture &call,
const GLfloat *value)
{
if (value == 0)
{
os << "nullptr";
}
else
{
os << "reinterpret_cast<const GLfloat *>("
<< static_cast<int>(reinterpret_cast<uintptr_t>(value)) << ")";
}
}
template <>
void WriteParamValueReplay<ParamType::TGLDEBUGPROCKHR>(std::ostream &os, void WriteParamValueReplay<ParamType::TGLDEBUGPROCKHR>(std::ostream &os,
const CallCapture &call, const CallCapture &call,
GLDEBUGPROCKHR value) GLDEBUGPROCKHR value)
......
...@@ -575,6 +575,11 @@ void WriteParamValueReplay<ParamType::TvoidConstPointer>(std::ostream &os, ...@@ -575,6 +575,11 @@ void WriteParamValueReplay<ParamType::TvoidConstPointer>(std::ostream &os,
const void *value); const void *value);
template <> template <>
void WriteParamValueReplay<ParamType::TGLfloatConstPointer>(std::ostream &os,
const CallCapture &call,
const GLfloat *value);
template <>
void WriteParamValueReplay<ParamType::TGLDEBUGPROCKHR>(std::ostream &os, void WriteParamValueReplay<ParamType::TGLDEBUGPROCKHR>(std::ostream &os,
const CallCapture &call, const CallCapture &call,
GLDEBUGPROCKHR value); GLDEBUGPROCKHR value);
......
...@@ -20,7 +20,7 @@ void CaptureClipPlanef_eqn(const State &glState, ...@@ -20,7 +20,7 @@ void CaptureClipPlanef_eqn(const State &glState,
const GLfloat *eqn, const GLfloat *eqn,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); CaptureMemory(eqn, 4 * sizeof(GLfloat), paramCapture);
} }
void CaptureClipPlanex_equation(const State &glState, void CaptureClipPlanex_equation(const State &glState,
...@@ -67,7 +67,7 @@ void CaptureGetClipPlanef_equation(const State &glState, ...@@ -67,7 +67,7 @@ void CaptureGetClipPlanef_equation(const State &glState,
GLfloat *equation, GLfloat *equation,
ParamCapture *paramCapture) ParamCapture *paramCapture)
{ {
UNIMPLEMENTED(); CaptureMemory(equation, 4 * sizeof(GLfloat), paramCapture);
} }
void CaptureGetClipPlanex_equation(const State &glState, void CaptureGetClipPlanex_equation(const State &glState,
......
...@@ -101,9 +101,6 @@ FramebufferObjectTest.TextureObjectDifferentFormats/* ...@@ -101,9 +101,6 @@ FramebufferObjectTest.TextureObjectDifferentFormats/*
BootAnimationTest.DefaultBootAnimation/* BootAnimationTest.DefaultBootAnimation/*
# ES1 compile failed tests # ES1 compile failed tests
ClipPlaneTest.InitialState/*
ClipPlaneTest.Negative/*
ClipPlaneTest.Set/*
CurrentColorTest.Set/* CurrentColorTest.Set/*
FogTest.NegativeParameter/* FogTest.NegativeParameter/*
FogTest.NegativeValues/* FogTest.NegativeValues/*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment