frame_capture_utils: Do not serialize 0 bindings.

Since we are only interested in the difference to non-default states, bindings with a zero ID should not be serialized. This resolves the comparision error in the GetTexLevelParameterTest.* tests. The test now do not need to be skipped. Bug: angleproject:5645 Change-Id: I887bc22b52a201c467c00c42f6ddb3b38895a7c4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739726Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

frame_capture_utils: Do not serialize 0 bindings.
9265d1e2 · Lubosz Sarnecki · Commit Bot · ff16821c · 9265d1e2 · 9265d1e2
Commit 9265d1e2 authored Mar 05, 2021 by Lubosz Sarnecki Committed by Commit Bot Mar 11, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 3 deletions

frame_capture_utils.cpp src/libANGLE/capture/frame_capture_utils.cpp +5 -1

capture_replay_expectations.txt ...ests/capture_replay_tests/capture_replay_expectations.txt +0 -2

No files found.
--- a/src/libANGLE/capture/frame_capture_utils.cpp
+++ b/src/libANGLE/capture/frame_capture_utils.cpp
@@ -85,7 +85,11 @@ void SerializeBindingPointerVector(
 {
    for (size_t i = 0; i < bindingPointerVector.size(); i++)
    {
-        bos->writeInt(bindingPointerVector[i].id().value);
+        // Do not serialize zero bindings, as this will create unwanted diffs
+        if (bindingPointerVector[i].id().value != 0)
+        {
+            bos->writeInt(bindingPointerVector[i].id().value);
+        }
    }
 }


--- a/src/tests/capture_replay_tests/capture_replay_expectations.txt
+++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt
@@ -26,7 +26,6 @@ DifferentStencilMasksTest.*
 EGLContextASANTest.*
 EGLContextSharingTest.TextureLifetime/*
 FramebufferTest.MultiContextNoRenderingFeedbackLoops/*
-GetTexLevelParameterTest.ExtensionStringExposed/*
 GLSLTest.InactiveVaryingInVertexActiveInFragment/*
 InstancingTest.LineLoop/*
 MaxTextureSizeTest.*
@@ -113,5 +112,4 @@ MipmapTest.DISABLED_ThreeLevelsInitData/*

 # Compile failed tests
 GetImageTest.*
-GetTexLevelParameterTest.Queries/*
 RobustResourceInitTest.*