Remove unnecessary checks when traversing nodes

src/compiler/translator/IntermNode.cpp

@@ -1047,6 +1047,7 @@ TIntermSwizzle::TIntermSwizzle(TIntermTyped *operand, const TVector<int> &swizzl
       mSwizzleOffsets(swizzleOffsets),
       mHasFoldedDuplicateOffsets(false)
 {
+    ASSERT(mOperand);
     ASSERT(mSwizzleOffsets.size() <= 4);
     promote();
 }
@@ -1054,12 +1055,15 @@ TIntermSwizzle::TIntermSwizzle(TIntermTyped *operand, const TVector<int> &swizzl
 TIntermUnary::TIntermUnary(TOperator op, TIntermTyped *operand, const TFunction *function)
     : TIntermOperator(op), mOperand(operand), mUseEmulatedFunction(false), mFunction(function)
 {
+    ASSERT(mOperand);
     promote();
 }
 
 TIntermBinary::TIntermBinary(TOperator op, TIntermTyped *left, TIntermTyped *right)
     : TIntermOperator(op), mLeft(left), mRight(right), mAddIndexClamp(false)
 {
+    ASSERT(mLeft);
+    ASSERT(mRight);
     promote();
 }
 
@@ -1087,6 +1091,9 @@ TIntermTernary::TIntermTernary(TIntermTyped *cond,
       mTrueExpression(trueExpression),
       mFalseExpression(falseExpression)
 {
+    ASSERT(mCondition);
+    ASSERT(mTrueExpression);
+    ASSERT(mFalseExpression);
     getTypePointer()->setQualifier(
         TIntermTernary::DetermineQualifier(cond, trueExpression, falseExpression));
 }

src/compiler/translator/tree_util/IntermTraverse.cpp

@@ -254,13 +254,12 @@ void TIntermTraverser::traverseBinary(TIntermBinary *node)
     //
     if (visit)
     {
-        if (node->getLeft())
-            node->getLeft()->traverse(this);
+        node->getLeft()->traverse(this);
 
         if (inVisit)
             visit = visitBinary(InVisit, node);
 
-        if (visit && node->getRight())
+        if (visit)
             node->getRight()->traverse(this);
     }
 
@@ -301,8 +300,7 @@ void TLValueTrackingTraverser::traverseBinary(TIntermBinary *node)
             setOperatorRequiresLValue(true);
         }
 
-        if (node->getLeft())
-            node->getLeft()->traverse(this);
+        node->getLeft()->traverse(this);
 
         if (inVisit)
             visit = visitBinary(InVisit, node);
@@ -320,7 +318,7 @@ void TLValueTrackingTraverser::traverseBinary(TIntermBinary *node)
             setInFunctionCallOutParameter(false);
         }
 
-        if (visit && node->getRight())
+        if (visit)
             node->getRight()->traverse(this);
 
         setOperatorRequiresLValue(parentOperatorRequiresLValue);
@@ -715,10 +713,8 @@ void TIntermTraverser::traverseTernary(TIntermTernary *node)
     if (visit)
     {
         node->getCondition()->traverse(this);
-        if (node->getTrueExpression())
-            node->getTrueExpression()->traverse(this);
-        if (node->getFalseExpression())
-            node->getFalseExpression()->traverse(this);
+        node->getTrueExpression()->traverse(this);
+        node->getFalseExpression()->traverse(this);
     }
 
     if (visit && postVisit)