Capture/Replay: Use BindAttribLocation to force MEC compat.

In some cases we'd end up with attributes that are optimized out by the GL driver. BindAttribLocation forces the programs to use the same attribute indexing numbers so that the command stream works mostly the same even if some attributes aren't active in the shader. Bug: angleproject:4598 Change-Id: I2d02dd38d29a1489706ae70bcc0b262b1c076942 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174266 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

Capture/Replay: Use BindAttribLocation to force MEC compat.
942796f6 · Jamie Madill · Commit Bot · e09f7a14 · 942796f6
Commit 942796f6 authored Apr 30, 2020 by Jamie Madill Committed by Commit Bot May 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

FrameCapture.cpp src/libANGLE/FrameCapture.cpp +9 -0

No files found.
--- a/src/libANGLE/FrameCapture.cpp
+++ b/src/libANGLE/FrameCapture.cpp
@@ -2286,6 +2286,15 @@ void CaptureMidExecutionSetup(const gl::Context *context,
                                                 varyingsStrings.data(), xfbMode));
        }

+        // Force the attributes to be bound the same way as in the existing program.
+        // This can affect attributes that are optimized out in some implementations.
+        for (const sh::ShaderVariable &attrib : program->getState().getProgramInputs())
+        {
+            ASSERT(attrib.location != -1);
+            cap(CaptureBindAttribLocation(
+                replayState, true, id, static_cast<GLuint>(attrib.location), attrib.name.c_str()));
+        }
+
        cap(CaptureLinkProgram(replayState, true, id));
        CaptureUpdateUniformLocations(program, setupCalls);
        CaptureUpdateUniformValues(replayState, context, program, setupCalls);