Skip to content

A
angle
Commit 9addf0cb by Tim Van Patten Committed by Commit Bot
Options

Vulkan: Enable Line Rasterization Emulation

Android requires the same line rasterization for Vulkan, so this CL will enabled that workaround. Bug: angleproject:2830 Test: dEQP-GLES2.functional.rasterization.primitives.line* Change-Id: Ic28dd2e54c5cb9b29f8592952b2c0f29a5f97fd5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1715207Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Reviewed-by: 's avatarCourtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
parent a79c2440
Showing with 5 additions and 6 deletions
src/libANGLE/renderer/vulkan/RendererVk.cpp
...@@ -1165,12 +1165,7 @@ gl::Version RendererVk::getMaxConformantESVersion() const ...@@ -1165,12 +1165,7 @@ gl::Version RendererVk::getMaxConformantESVersion() const
void RendererVk::initFeatures(const ExtensionNameList &deviceExtensionNames) void RendererVk::initFeatures(const ExtensionNameList &deviceExtensionNames)
{ {
// Use OpenGL line rasterization rules by default. // Use OpenGL line rasterization rules by default.
// TODO(jmadill): Fix Android support. http://anglebug.com/2830
#if defined(ANGLE_PLATFORM_ANDROID)
mFeatures.basicGLLineRasterization.enabled = false;
#else
mFeatures.basicGLLineRasterization.enabled = true; mFeatures.basicGLLineRasterization.enabled = true;
#endif // defined(ANGLE_PLATFORM_ANDROID)
if ((mPhysicalDeviceProperties.apiVersion >= VK_MAKE_VERSION(1, 1, 0)) || if ((mPhysicalDeviceProperties.apiVersion >= VK_MAKE_VERSION(1, 1, 0)) ||
ExtensionFound(VK_KHR_MAINTENANCE1_EXTENSION_NAME, deviceExtensionNames)) ExtensionFound(VK_KHR_MAINTENANCE1_EXTENSION_NAME, deviceExtensionNames))
......
src/tests/deqp_support/deqp_gles2_test_expectations.txt
...@@ -342,7 +342,7 @@ ...@@ -342,7 +342,7 @@
2549 VULKAN ANDROID : dEQP-GLES2.functional.fragment_ops.depth_stencil.stencil* = SKIP 2549 VULKAN ANDROID : dEQP-GLES2.functional.fragment_ops.depth_stencil.stencil* = SKIP
// Line segment rasterization has a bug that affects Android configs. // Line segment rasterization has a bug that affects Android configs.
2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line* = SKIP 2830 VULKAN ANDROID : dEQP-GLES2.functional.rasterization.primitives.line* = FAIL
// Passes on Pixel XL. Fails on 5x and Pixel 2. Might be fixed in latest driver. // Passes on Pixel XL. Fails on 5x and Pixel 2. Might be fixed in latest driver.
2609 VULKAN ANDROID : dEQP-GLES2.functional.texture.mipmap.cube.generate.* = SKIP 2609 VULKAN ANDROID : dEQP-GLES2.functional.texture.mipmap.cube.generate.* = SKIP
...@@ -390,6 +390,7 @@ ...@@ -390,6 +390,7 @@
// Fails after OpenGL line rasterization rules implementation. Possibly a bug in FragCoord. // Fails after OpenGL line rasterization rules implementation. Possibly a bug in FragCoord.
2809 VULKAN WIN AMD : dEQP-GLES2.functional.clipping.line.long_line_clip = FAIL 2809 VULKAN WIN AMD : dEQP-GLES2.functional.clipping.line.long_line_clip = FAIL
2830 VULKAN ANDROID : dEQP-GLES2.functional.clipping.line.long_line_clip = FAIL
// Polygon offset failures // Polygon offset failures
3301 VULKAN WIN AMD : dEQP-GLES2.functional.polygon_offset.default_result_depth_clamp = FAIL 3301 VULKAN WIN AMD : dEQP-GLES2.functional.polygon_offset.default_result_depth_clamp = FAIL
......
src/tests/deqp_support/deqp_gles3_test_expectations.txt
...@@ -646,6 +646,9 @@ ...@@ -646,6 +646,9 @@
2672 VULKAN : dEQP-GLES3.functional.draw.draw_elements_instanced.line_loop.* = SKIP 2672 VULKAN : dEQP-GLES3.functional.draw.draw_elements_instanced.line_loop.* = SKIP
2672 VULKAN : dEQP-GLES3.functional.draw.random.* = SKIP 2672 VULKAN : dEQP-GLES3.functional.draw.random.* = SKIP
// Fails after OpenGL line rasterization rules implementation. Possibly a bug in FragCoord.
2830 VULKAN ANDROID : dEQP-GLES3.functional.clipping.line.long_line_clip = FAIL
// Base/Max levels: // Base/Max levels:
3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_2d_texture_base_level_gettexparameter* = SKIP 3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_2d_texture_base_level_gettexparameter* = SKIP
3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_3d_texture_base_level_gettexparameter* = SKIP 3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_3d_texture_base_level_gettexparameter* = SKIP
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment