Commit 9ba86e06 by Cody Northrop Committed by Angle LUCI CQ

Revert "FrameCapture: Write the frame cpp file even if frame is empty"

This reverts commit 6619c464. Reason for revert: breaks MEC. Bug: angleproject:5999 Original change's description: > FrameCapture: Write the frame cpp file even if frame is empty > > The index file will add a reference to this file, and the replay will > also expect that the frame execution function and the context function > exist, so write the file even if the frame is empty > > Bug: angleproject:5939 > Change-Id: I265d061fdae51b86131d145116ad1c0f9ca8c93f > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882581 > Commit-Queue: Gert Wollny <gert.wollny@collabora.com> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> Bug: angleproject:5939 Change-Id: I759d44ba847c69faf1caf97a9818836d1be3b058 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2937737Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarTim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
parent cf853b30
...@@ -4590,7 +4590,7 @@ void FrameCapture::onEndFrame(const gl::Context *context) ...@@ -4590,7 +4590,7 @@ void FrameCapture::onEndFrame(const gl::Context *context)
} }
// Note that we currently capture before the start frame to collect shader and program sources. // Note that we currently capture before the start frame to collect shader and program sources.
if (isCaptureActive()) if (!mFrameCalls.empty() && isCaptureActive())
{ {
if (mIsFirstFrame) if (mIsFirstFrame)
{ {
......
...@@ -103,6 +103,9 @@ EGLProgramCacheControlTest.SaveAndReload/* ...@@ -103,6 +103,9 @@ EGLProgramCacheControlTest.SaveAndReload/*
LineLoopTest.DISABLED_DrawArraysWithLargeCount/* LineLoopTest.DISABLED_DrawArraysWithLargeCount/*
MipmapTest.DISABLED_ThreeLevelsInitData/* MipmapTest.DISABLED_ThreeLevelsInitData/*
# Compile failed tests
RobustResourceInitTest.SurfaceInitializedAfterSwap/*
# ES1 crashed tests # ES1 crashed tests
FramebufferObjectTest.FramebufferObject/* FramebufferObjectTest.FramebufferObject/*
FramebufferObjectTest.RenderbufferObject/* FramebufferObjectTest.RenderbufferObject/*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment