Skip to content

A
angle
Commit 9dc0a247 by apatrick@chromium.org
Options

Enable warnings as errors.

I didn't do it for translator_common though because it contains automatically generated code. This is improve the signal to noise ratio in the chromium build logs. Review URL: https://codereview.appspot.com/5572055 git-svn-id: https://angleproject.googlecode.com/svn/trunk@960 736b8ea6-26fd-11df-bfd4-992fa37f6226
parent 7e84fd68
Showing with 28 additions and 1 deletion
build/common.gypi
...@@ -8,6 +8,18 @@ ...@@ -8,6 +8,18 @@
}, },
'target_defaults': { 'target_defaults': {
'default_configuration': 'Debug', 'default_configuration': 'Debug',
'variables': {
'warn_as_error%': 1,
},
'target_conditions': [
['warn_as_error == 1', {
'msvs_settings': {
'VCCLCompilerTool': {
'WarnAsError': 'true',
},
},
}],
],
'configurations': { 'configurations': {
'Common': { 'Common': {
'abstract': 1, 'abstract': 1,
......
src/build_angle.gyp
...@@ -13,6 +13,9 @@ ...@@ -13,6 +13,9 @@
{ {
'target_name': 'translator_common', 'target_name': 'translator_common',
'type': 'static_library', 'type': 'static_library',
'variables': {
'warn_as_error': 0,
},
'include_dirs': [ 'include_dirs': [
'.', '.',
'../include', '../include',
......
src/common/version.h
#define MAJOR_VERSION 1 #define MAJOR_VERSION 1
#define MINOR_VERSION 0 #define MINOR_VERSION 0
#define BUILD_VERSION 0 #define BUILD_VERSION 0
#define BUILD_REVISION 957 #define BUILD_REVISION 960
#define STRINGIFY(x) #x #define STRINGIFY(x) #x
#define MACRO_STRINGIFY(x) STRINGIFY(x) #define MACRO_STRINGIFY(x) STRINGIFY(x)
......
src/compiler/translator_hlsl.vcproj
...@@ -52,6 +52,7 @@ ...@@ -52,6 +52,7 @@
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
WarningLevel="3" WarningLevel="3"
DebugInformationFormat="4" DebugInformationFormat="4"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -116,6 +117,7 @@ ...@@ -116,6 +117,7 @@
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
WarningLevel="3" WarningLevel="3"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -179,6 +181,7 @@ ...@@ -179,6 +181,7 @@
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
WarningLevel="3" WarningLevel="3"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -244,6 +247,7 @@ ...@@ -244,6 +247,7 @@
UsePrecompiledHeader="0" UsePrecompiledHeader="0"
WarningLevel="3" WarningLevel="3"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
......
src/libEGL/libEGL.vcproj
...@@ -53,6 +53,7 @@ ...@@ -53,6 +53,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="4" DebugInformationFormat="4"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -132,6 +133,7 @@ ...@@ -132,6 +133,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -214,6 +216,7 @@ ...@@ -214,6 +216,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -294,6 +297,7 @@ ...@@ -294,6 +297,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
......
src/libGLESv2/libGLESv2.vcproj
...@@ -53,6 +53,7 @@ ...@@ -53,6 +53,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="4" DebugInformationFormat="4"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -131,6 +132,7 @@ ...@@ -131,6 +132,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -213,6 +215,7 @@ ...@@ -213,6 +215,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
...@@ -292,6 +295,7 @@ ...@@ -292,6 +295,7 @@
WarningLevel="3" WarningLevel="3"
Detect64BitPortabilityProblems="false" Detect64BitPortabilityProblems="false"
DebugInformationFormat="3" DebugInformationFormat="3"
WarnAsError="true"
/> />
<Tool <Tool
Name="VCManagedResourceCompilerTool" Name="VCManagedResourceCompilerTool"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment