perf_tests: Normalize MS counts in EGL init test.

The un-normalized values depend on the number of frames rendered, so if we optimize down one time, the other ms values all increase, because we are rendering more frames. This generates spurious perf alerts from the perf dashboard. BUG=None Change-Id: I1bc480141a8cad7eee96bcdf4d6747a3cbae30f2 Reviewed-on: https://chromium-review.googlesource.com/280980Reviewed-by: Zhenyao Mo <zmo@chromium.org> Tested-by: Jamie Madill <jmadill@chromium.org>

perf_tests: Normalize MS counts in EGL init test.
9e582b93 · Jamie Madill · 7d112bb9 · 9e582b93 · 9e582b93 · 9e582b93
Commit 9e582b93 authored Jun 22, 2015 by Jamie Madill
Showing with 11 additions and 3 deletions

ANGLEPerfTest.cpp src/tests/perf_tests/ANGLEPerfTest.cpp +5 -0

ANGLEPerfTest.h src/tests/perf_tests/ANGLEPerfTest.h +3 -0

EGLInitializePerf.cpp src/tests/perf_tests/EGLInitializePerf.cpp +3 -3

No files found.
--- a/src/tests/perf_tests/ANGLEPerfTest.cpp
+++ b/src/tests/perf_tests/ANGLEPerfTest.cpp
@@ -68,6 +68,11 @@ void ANGLEPerfTest::TearDown()
    printResult("score", static_cast<size_t>(mNumFrames), "score", true);
 }

+double ANGLEPerfTest::normalizedTime(size_t value) const
+{
+    return static_cast<double>(value) / static_cast<double>(mNumFrames);
+}
+
 std::string RenderTestParams::suffix() const
 {
    switch (getRenderer())

--- a/src/tests/perf_tests/ANGLEPerfTest.h
+++ b/src/tests/perf_tests/ANGLEPerfTest.h
@@ -45,6 +45,9 @@ class ANGLEPerfTest : public testing::Test, angle::NonCopyable
    void SetUp() override;
    void TearDown() override;

+    // Normalize a time value according to the number of test loop iterations (mFrameCount)
+    double normalizedTime(size_t value) const;
+
    std::string mName;
    std::string mSuffix;


--- a/src/tests/perf_tests/EGLInitializePerf.cpp
+++ b/src/tests/perf_tests/EGLInitializePerf.cpp
@@ -149,9 +149,9 @@ void EGLInitializePerfTest::step(float dt, double totalTime)
 void EGLInitializePerfTest::TearDown()
 {
    ANGLEPerfTest::TearDown();
-    printResult("LoadDLLs", mCapturePlatform.getLoadDLLsMS(), "ms", true);
-    printResult("D3D11CreateDevice", mCapturePlatform.getCreateDeviceMS(), "ms", true);
-    printResult("InitResources", mCapturePlatform.getInitResourcesMS(), "ms", true);
+    printResult("LoadDLLs", normalizedTime(mCapturePlatform.getLoadDLLsMS()), "ms", true);
+    printResult("D3D11CreateDevice", normalizedTime(mCapturePlatform.getCreateDeviceMS()), "ms", true);
+    printResult("InitResources", normalizedTime(mCapturePlatform.getInitResourcesMS()), "ms", true);

    ANGLEPlatformShutdown();
 }