Fix use-after-free in drawQuad with useVertexBuffer false

quadVertices.data() pointer needs to remain valid until drawArrays is called. To guarantee that quadVertices should stay in the stack until the end of drawQuad(). BUG=angleproject:2533 TEST=angle_end2end_tests Change-Id: I263262db9a9ed9c9cd0d8679addd09677ad7179e Reviewed-on: https://chromium-review.googlesource.com/1046600 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Fix use-after-free in drawQuad with useVertexBuffer false
9f394f8c · Olli Etuaho · Commit Bot · fad918f8 · 9f394f8c
Commit 9f394f8c authored May 07, 2018 by Olli Etuaho Committed by Commit Bot May 07, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

ANGLETest.cpp src/tests/test_utils/ANGLETest.cpp +3 -1

No files found.
--- a/src/tests/test_utils/ANGLETest.cpp
+++ b/src/tests/test_utils/ANGLETest.cpp
@@ -464,6 +464,8 @@ void ANGLETestBase::drawQuad(GLuint program,
    GLint positionLocation = glGetAttribLocation(program, positionAttribName.c_str());
+    std::array<angle::Vector3, 6> quadVertices;
    if (useVertexBuffer)
    {
        setupQuadVertexBuffer(positionAttribZ, positionAttribXYScale);
@@ -472,7 +474,7 @@ void ANGLETestBase::drawQuad(GLuint program,
    }
    else
    {
-        auto quadVertices = GetQuadVertices();
+        quadVertices = GetQuadVertices();
        for (angle::Vector3 &vertex : quadVertices)
        {
            vertex.x() *= positionAttribXYScale;