Skip to content

A
angle
Commit a0d010ab by Shahbaz Youssefi Committed by Commit Bot
Options

Disable atomic counter buffer tests on AMD/Windows/GL

Second attempt at fixing this bot: https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20Release%20%28AMD%20RX%20550%29 Bug: angleproject:3738 Change-Id: I8e8626cc911df9dae82c542b2dde8696f10e49bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1731130Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent 868f5fa0
Showing with 16 additions and 16 deletions
src/tests/gl_tests/AtomicCounterBufferTest.cpp
...@@ -32,8 +32,8 @@ class AtomicCounterBufferTest : public ANGLETest ...@@ -32,8 +32,8 @@ class AtomicCounterBufferTest : public ANGLETest
// Test GL_ATOMIC_COUNTER_BUFFER is not supported with version lower than ES31. // Test GL_ATOMIC_COUNTER_BUFFER is not supported with version lower than ES31.
TEST_P(AtomicCounterBufferTest, AtomicCounterBufferBindings) TEST_P(AtomicCounterBufferTest, AtomicCounterBufferBindings)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
ASSERT_EQ(3, getClientMajorVersion()); ASSERT_EQ(3, getClientMajorVersion());
GLBuffer atomicCounterBuffer; GLBuffer atomicCounterBuffer;
...@@ -54,8 +54,8 @@ class AtomicCounterBufferTest31 : public AtomicCounterBufferTest ...@@ -54,8 +54,8 @@ class AtomicCounterBufferTest31 : public AtomicCounterBufferTest
// Linking should fail if counters in vertex shader exceed gl_MaxVertexAtomicCounters. // Linking should fail if counters in vertex shader exceed gl_MaxVertexAtomicCounters.
TEST_P(AtomicCounterBufferTest31, ExceedMaxVertexAtomicCounters) TEST_P(AtomicCounterBufferTest31, ExceedMaxVertexAtomicCounters)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
constexpr char kVS[] = constexpr char kVS[] =
"#version 310 es\n" "#version 310 es\n"
...@@ -78,8 +78,8 @@ TEST_P(AtomicCounterBufferTest31, ExceedMaxVertexAtomicCounters) ...@@ -78,8 +78,8 @@ TEST_P(AtomicCounterBufferTest31, ExceedMaxVertexAtomicCounters)
// GLSL ES Spec 3.10.4, section 9.2.1. // GLSL ES Spec 3.10.4, section 9.2.1.
TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecified) TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecified)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
constexpr char kVS[] = constexpr char kVS[] =
"#version 310 es\n" "#version 310 es\n"
...@@ -103,8 +103,8 @@ TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecified) ...@@ -103,8 +103,8 @@ TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecified)
// value. // value.
TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecifiedWithSameValue) TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecifiedWithSameValue)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
constexpr char kVS[] = constexpr char kVS[] =
"#version 310 es\n" "#version 310 es\n"
...@@ -127,8 +127,8 @@ TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecifiedWithSameValue) ...@@ -127,8 +127,8 @@ TEST_P(AtomicCounterBufferTest31, OffsetNotAllSpecifiedWithSameValue)
// Tests atomic counter reads using compute shaders. Used as a sanity check for the translator. // Tests atomic counter reads using compute shaders. Used as a sanity check for the translator.
TEST_P(AtomicCounterBufferTest31, AtomicCounterReadCompute) TEST_P(AtomicCounterBufferTest31, AtomicCounterReadCompute)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
// Skipping due to a bug on the Adreno OpenGLES Android driver. // Skipping due to a bug on the Adreno OpenGLES Android driver.
// http://anglebug.com/2925 // http://anglebug.com/2925
...@@ -158,8 +158,8 @@ void main() ...@@ -158,8 +158,8 @@ void main()
// Test atomic counter read. // Test atomic counter read.
TEST_P(AtomicCounterBufferTest31, AtomicCounterRead) TEST_P(AtomicCounterBufferTest31, AtomicCounterRead)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
// Skipping test while we work on enabling atomic counter buffer support in th D3D renderer. // Skipping test while we work on enabling atomic counter buffer support in th D3D renderer.
// http://anglebug.com/1729 // http://anglebug.com/1729
...@@ -197,8 +197,8 @@ TEST_P(AtomicCounterBufferTest31, AtomicCounterRead) ...@@ -197,8 +197,8 @@ TEST_P(AtomicCounterBufferTest31, AtomicCounterRead)
// Test atomic counter increment and decrement. // Test atomic counter increment and decrement.
TEST_P(AtomicCounterBufferTest31, AtomicCounterIncrementAndDecrement) TEST_P(AtomicCounterBufferTest31, AtomicCounterIncrementAndDecrement)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
constexpr char kCS[] = constexpr char kCS[] =
"#version 310 es\n" "#version 310 es\n"
...@@ -241,8 +241,8 @@ TEST_P(AtomicCounterBufferTest31, AtomicCounterIncrementAndDecrement) ...@@ -241,8 +241,8 @@ TEST_P(AtomicCounterBufferTest31, AtomicCounterIncrementAndDecrement)
// Tests multiple atomic counter buffers. // Tests multiple atomic counter buffers.
TEST_P(AtomicCounterBufferTest31, AtomicCounterMultipleBuffers) TEST_P(AtomicCounterBufferTest31, AtomicCounterMultipleBuffers)
{ {
// Causes crashes in the subsequent OpenGL testing of this function. http://anglebug.com/3738 // Crashes in older drivers. http://anglebug.com/3738
ANGLE_SKIP_TEST_IF(IsVulkan() && IsWindows() && IsAMD()); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsWindows() && IsAMD());
GLint maxAtomicCounterBuffers = 0; GLint maxAtomicCounterBuffers = 0;
glGetIntegerv(GL_MAX_COMPUTE_ATOMIC_COUNTER_BUFFERS, &maxAtomicCounterBuffers); glGetIntegerv(GL_MAX_COMPUTE_ATOMIC_COUNTER_BUFFERS, &maxAtomicCounterBuffers);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment