Skip to content

A
angle
Commit a2161335 by Jonah Ryan-Davis
Options

[M89] GL: Remove in-thread link status check from parallel link path.

A call to checkLinkStatus was wrongly placed in the nativeParallelCompile path, which ended up blocking on shader linking, rendering parallel compilation useless. Bug: chromium:1169477 Bug: chromium:1099763 Change-Id: Id2c5fe31e651abac76207c93919fd83d79f30556 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2647987Reviewed-by: 's avatarShahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> (cherry picked from commit f9afaaee) Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2655797Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com>
parent d392af02
Showing with 1 addition and 2 deletions
src/libANGLE/renderer/gl/ProgramGL.cpp
...@@ -476,8 +476,7 @@ std::unique_ptr<LinkEvent> ProgramGL::link(const gl::Context *context, ...@@ -476,8 +476,7 @@ std::unique_ptr<LinkEvent> ProgramGL::link(const gl::Context *context,
if (mRenderer->hasNativeParallelCompile()) if (mRenderer->hasNativeParallelCompile())
{ {
mFunctions->linkProgram(mProgramID); mFunctions->linkProgram(mProgramID);
// Verify the link
checkLinkStatus(infoLog);
return std::make_unique<LinkEventNativeParallel>(postLinkImplTask, mFunctions, mProgramID); return std::make_unique<LinkEventNativeParallel>(postLinkImplTask, mFunctions, mProgramID);
} }
else if (workerPool->isAsync() && else if (workerPool->isAsync() &&
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment