Skip to content

A
angle
Commit a4d05638 by Jamie Madill Committed by Commit Bot
Options

Capture/Replay: Don't serialize compile resources string.

The resources string gets changed dynamically during capture. This breaks the regression tests because they were comparing for identity. Bug: angleproject:5530 Change-Id: I0734f735577a5ff4c9083adb8f25a37aad3c0e37 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2634830 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarTim Van Patten <timvp@google.com>
parent 80b45c33
Showing with 2 additions and 3 deletions
src/libANGLE/frame_capture_utils.cpp
...@@ -684,9 +684,9 @@ void SerializeShader(gl::BinaryOutputStream *bos, gl::Shader *shader) ...@@ -684,9 +684,9 @@ void SerializeShader(gl::BinaryOutputStream *bos, gl::Shader *shader)
bos->writeInt(shader->getHandle().value); bos->writeInt(shader->getHandle().value);
bos->writeInt(shader->getRefCount()); bos->writeInt(shader->getRefCount());
bos->writeBool(shader->isFlaggedForDeletion()); bos->writeBool(shader->isFlaggedForDeletion());
// does not serialize mType because it is already serialized in SerializeShaderState // Do not serialize mType because it is already serialized in SerializeShaderState.
bos->writeString(shader->getInfoLogString()); bos->writeString(shader->getInfoLogString());
bos->writeString(shader->getCompilerResourcesString()); // Do not serialize compiler resources string because it can vary between test modes.
bos->writeInt(shader->getCurrentMaxComputeWorkGroupInvocations()); bos->writeInt(shader->getCurrentMaxComputeWorkGroupInvocations());
bos->writeInt(shader->getMaxComputeSharedMemory()); bos->writeInt(shader->getMaxComputeSharedMemory());
} }
......
src/tests/capture_replay_tests/capture_replay_expectations.txt
...@@ -74,7 +74,6 @@ OcclusionQueriesTest.* ...@@ -74,7 +74,6 @@ OcclusionQueriesTest.*
PBOExtensionTest.* PBOExtensionTest.*
PixmapTest.Clearing/ES2_Vulkan PixmapTest.Clearing/ES2_Vulkan
SemaphoreTest.SemaphoreShouldBeSemaphore/ES2_Vulkan SemaphoreTest.SemaphoreShouldBeSemaphore/ES2_Vulkan
SimpleOperationTest.DrawQuad/ES2_Vulkan
SRGBFramebufferTest.Validation/ES2_Vulkan SRGBFramebufferTest.Validation/ES2_Vulkan
StateChangeRenderTest.GenerateMipmap/ES2_Vulkan StateChangeRenderTest.GenerateMipmap/ES2_Vulkan
SyncQueriesTest.* SyncQueriesTest.*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment