Vulkan: fix depth/stencil-only blit

The draw-call path was outputting color unconditionally even though only depth/stencil was written by the shader, causing flakiness. Bug: angleproject:3200 Change-Id: I1b28e37160153863e7e6c2875c3002abf4ec176b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682729Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Vulkan: fix depth/stencil-only blit
a845b599 · Shahbaz Youssefi · Commit Bot · be3d2d98 · a845b599
Commit a845b599 authored Jul 02, 2019 by Shahbaz Youssefi Committed by Commit Bot Jul 02, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 2 deletions

UtilsVk.cpp src/libANGLE/renderer/vulkan/UtilsVk.cpp +9 -2

No files found.
--- a/src/libANGLE/renderer/vulkan/UtilsVk.cpp
+++ b/src/libANGLE/renderer/vulkan/UtilsVk.cpp
@@ -977,8 +977,15 @@ angle::Result UtilsVk::blitResolveImpl(ContextVk *contextVk,

    vk::GraphicsPipelineDesc pipelineDesc;
    pipelineDesc.initDefaults();
-    pipelineDesc.setColorWriteMask(kAllColorComponents,
-                                   framebuffer->getEmulatedAlphaAttachmentMask());
+    if (blitColor)
+    {
+        pipelineDesc.setColorWriteMask(kAllColorComponents,
+                                       framebuffer->getEmulatedAlphaAttachmentMask());
+    }
+    else
+    {
+        pipelineDesc.setColorWriteMask(0, gl::DrawBufferMask());
+    }
    pipelineDesc.setRenderPassDesc(framebuffer->getRenderPassDesc());
    pipelineDesc.setDepthTestEnabled(blitDepth);
    pipelineDesc.setDepthWriteEnabled(blitDepth);