Tweaks to presubmit script.

- run the same checks on 'git cl upload' as 'git cl pre' - show the problematic line on non-ascii presubmit check Bug: angleproject:4601 Change-Id: I321e22fd49f7a83aa062ebae01d13476e57044e3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174075 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by: Tim Van Patten <timvp@google.com>

Tweaks to presubmit script.
a89750ec · Jamie Madill · Commit Bot · 85ae836f · a89750ec
Commit a89750ec authored Apr 30, 2020 by Jamie Madill Committed by Commit Bot May 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 10 deletions

PRESUBMIT.py PRESUBMIT.py +2 -10

No files found.
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -214,7 +214,7 @@ def _CheckNonAsciiInSourceFiles(input_api, output_api):
    for f in input_api.AffectedSourceFiles(implementation_and_headers):
        for (num, line) in f.ChangedContents():
            if not is_ascii(line):
-                files_with_non_ascii.append(f)
+                files_with_non_ascii.append("%s: %s" % (f, line))
                break
    if files_with_non_ascii:
@@ -244,12 +244,4 @@ def CheckChangeOnUpload(input_api, output_api):
 def CheckChangeOnCommit(input_api, output_api):
-    results = []
+    return CheckChangeOnUpload(input_api, output_api)
-    results.extend(_CheckCodeGeneration(input_api, output_api))
-    results.extend(
-        input_api.canned_checks.CheckPatchFormatted(
-            input_api, output_api, result_factory=output_api.PresubmitError))
-    results.extend(_CheckChangeHasBugField(input_api, output_api))
-    results.extend(_CheckExportValidity(input_api, output_api))
-    results.extend(input_api.canned_checks.CheckChangeHasDescription(input_api, output_api))
-    return results