Skip to content

A
angle
Commit a8e6a463 by Jamie Madill Committed by Commit Bot
Options

Suppress Vulkan RobustResourceInit tests.

These tests are flaky because of a bug in ANGLE's Vulkan robust resource init. Mark them as failing until we can resolve the bug. Bug: angleproject:4255 Bug: angleproject:4384 Change-Id: I8e18a8532850848fc7a25e137dce27dd0d19fa55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046053Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 0a6e118d
Showing with 26 additions and 4 deletions
src/tests/gl_tests/RobustResourceInitTest.cpp
...@@ -528,6 +528,9 @@ TEST_P(RobustResourceInitTest, ReadingUninitializedTexture) ...@@ -528,6 +528,9 @@ TEST_P(RobustResourceInitTest, ReadingUninitializedTexture)
{ {
ANGLE_SKIP_TEST_IF(!hasGLExtension()); ANGLE_SKIP_TEST_IF(!hasGLExtension());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
GLTexture tex; GLTexture tex;
setupTexture(&tex); setupTexture(&tex);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr); glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
...@@ -544,6 +547,9 @@ TEST_P(RobustResourceInitTest, ReuploadingClearsTexture) ...@@ -544,6 +547,9 @@ TEST_P(RobustResourceInitTest, ReuploadingClearsTexture)
// crbug.com/826576 // crbug.com/826576
ANGLE_SKIP_TEST_IF(IsOSX() && IsNVIDIA() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsNVIDIA() && IsDesktopOpenGL());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
// Put some data into the texture // Put some data into the texture
std::array<GLColor, kWidth * kHeight> data; std::array<GLColor, kWidth * kHeight> data;
data.fill(GLColor::white); data.fill(GLColor::white);
...@@ -568,6 +574,9 @@ TEST_P(RobustResourceInitTest, TexImageThenSubImage) ...@@ -568,6 +574,9 @@ TEST_P(RobustResourceInitTest, TexImageThenSubImage)
// http://anglebug.com/2407, but only fails on Nexus devices // http://anglebug.com/2407, but only fails on Nexus devices
ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsOpenGLES()); ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsOpenGLES());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
// Put some data into the texture // Put some data into the texture
GLTexture tex; GLTexture tex;
...@@ -594,6 +603,9 @@ TEST_P(RobustResourceInitTestES3, ReadingUninitialized3DTexture) ...@@ -594,6 +603,9 @@ TEST_P(RobustResourceInitTestES3, ReadingUninitialized3DTexture)
{ {
ANGLE_SKIP_TEST_IF(!hasGLExtension()); ANGLE_SKIP_TEST_IF(!hasGLExtension());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
GLTexture tex; GLTexture tex;
setup3DTexture(&tex); setup3DTexture(&tex);
glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA, kWidth, kHeight, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE, glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA, kWidth, kHeight, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE,
...@@ -756,6 +768,9 @@ TEST_P(RobustResourceInitTest, UninitializedPartsOfCopied2DTexturesAreBlack) ...@@ -756,6 +768,9 @@ TEST_P(RobustResourceInitTest, UninitializedPartsOfCopied2DTexturesAreBlack)
{ {
ANGLE_SKIP_TEST_IF(!hasGLExtension()); ANGLE_SKIP_TEST_IF(!hasGLExtension());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
GLTexture tex; GLTexture tex;
setupTexture(&tex); setupTexture(&tex);
GLFramebuffer fbo; GLFramebuffer fbo;
...@@ -790,6 +805,9 @@ TEST_P(RobustResourceInitTestES3, ReadingOutOfBoundsCopiedTextureWithUnpackBuffe ...@@ -790,6 +805,9 @@ TEST_P(RobustResourceInitTestES3, ReadingOutOfBoundsCopiedTextureWithUnpackBuffe
// glCopyTextureCHROMIUM to copy GL_ALPHA into GL_RGBA // glCopyTextureCHROMIUM to copy GL_ALPHA into GL_RGBA
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_CHROMIUM_copy_texture")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_CHROMIUM_copy_texture"));
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
GLFramebuffer fbo; GLFramebuffer fbo;
glBindFramebuffer(GL_FRAMEBUFFER, fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo);
GLRenderbuffer rbo; GLRenderbuffer rbo;
...@@ -840,10 +858,8 @@ TEST_P(RobustResourceInitTest, ReadingOutOfBoundsCopiedTexture) ...@@ -840,10 +858,8 @@ TEST_P(RobustResourceInitTest, ReadingOutOfBoundsCopiedTexture)
{ {
ANGLE_SKIP_TEST_IF(!hasGLExtension()); ANGLE_SKIP_TEST_IF(!hasGLExtension());
// Flaky failure on Linux / NV / Vulkan when run in a sequence. http://anglebug.com/3416 // http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan() && IsNVIDIA() && IsLinux()); ANGLE_SKIP_TEST_IF(IsVulkan());
// http://anglebug.com/4092
ANGLE_SKIP_TEST_IF(IsWindows() && IsVulkan());
GLTexture tex; GLTexture tex;
setupTexture(&tex); setupTexture(&tex);
...@@ -930,6 +946,9 @@ TEST_P(RobustResourceInitTest, Texture) ...@@ -930,6 +946,9 @@ TEST_P(RobustResourceInitTest, Texture)
// Flaky failure on Linux / NV / Vulkan when run in a sequence. http://anglebug.com/3416 // Flaky failure on Linux / NV / Vulkan when run in a sequence. http://anglebug.com/3416
ANGLE_SKIP_TEST_IF(IsVulkan() && IsNVIDIA() && IsLinux()); ANGLE_SKIP_TEST_IF(IsVulkan() && IsNVIDIA() && IsLinux());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
GLTexture texture; GLTexture texture;
glBindTexture(GL_TEXTURE_2D, texture); glBindTexture(GL_TEXTURE_2D, texture);
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr); glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
...@@ -1616,6 +1635,9 @@ TEST_P(RobustResourceInitTestES3, Texture2DArray) ...@@ -1616,6 +1635,9 @@ TEST_P(RobustResourceInitTestES3, Texture2DArray)
{ {
ANGLE_SKIP_TEST_IF(!hasGLExtension()); ANGLE_SKIP_TEST_IF(!hasGLExtension());
// http://anglebug.com/4255
ANGLE_SKIP_TEST_IF(IsVulkan());
constexpr int kSize = 1024; constexpr int kSize = 1024;
constexpr int kLayers = 8; constexpr int kLayers = 8;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment