ES31: Add support for GL_DISPATCH_INDIRECT_BUFFER_BINDING binding point

src/libANGLE/ContextState.cpp

@@ -665,6 +665,7 @@ bool ValidationContext::getQueryParameterInfo(GLenum pname, GLenum *type, unsign
     {
         case GL_ATOMIC_COUNTER_BUFFER_BINDING:
         case GL_DRAW_INDIRECT_BUFFER_BINDING:
+        case GL_DISPATCH_INDIRECT_BUFFER_BINDING:
         case GL_MAX_FRAMEBUFFER_WIDTH:
         case GL_MAX_FRAMEBUFFER_HEIGHT:
         case GL_MAX_FRAMEBUFFER_SAMPLES:

src/libANGLE/State.cpp

@@ -1256,6 +1256,10 @@ void State::setBufferBinding(const Context *context, BufferBinding target, Buffe
             mBoundBuffers[target].set(context, buffer);
             mDirtyBits.set(DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING);
             break;
+        case BufferBinding::DispatchIndirect:
+            mBoundBuffers[target].set(context, buffer);
+            mDirtyBits.set(DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING);
+            break;
         case BufferBinding::TransformFeedback:
             if (mTransformFeedback.get() != nullptr)
             {
@@ -2046,6 +2050,9 @@ void State::getIntegerv(const Context *context, GLenum pname, GLint *params)
       case GL_SHADER_STORAGE_BUFFER_BINDING:
           *params = mBoundBuffers[BufferBinding::ShaderStorage].id();
           break;
+      case GL_DISPATCH_INDIRECT_BUFFER_BINDING:
+          *params = mBoundBuffers[BufferBinding::DispatchIndirect].id();
+          break;
       default:
         UNREACHABLE();
         break;

src/libANGLE/State.h

@@ -394,6 +394,7 @@ class State : public OnAttachmentDirtyReceiver, angle::NonCopyable
         DIRTY_BIT_RENDERBUFFER_BINDING,
         DIRTY_BIT_VERTEX_ARRAY_BINDING,
         DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING,
+        DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING,
         DIRTY_BIT_SHADER_STORAGE_BUFFER_BINDING,
         DIRTY_BIT_PROGRAM_BINDING,
         DIRTY_BIT_PROGRAM_EXECUTABLE,

src/libANGLE/renderer/gl/StateManagerGL.cpp

@@ -1931,6 +1931,9 @@ void StateManagerGL::syncState(const gl::Context *context, const gl::State::Dirt
             case gl::State::DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING:
                 // TODO: implement this
                 break;
+            case gl::State::DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING:
+                // TODO(jiajia.qin@intel.com): implement this
+                break;
             case gl::State::DIRTY_BIT_PROGRAM_BINDING:
             {
                 mProgramTexturesAndSamplersDirty = true;

src/libANGLE/renderer/vulkan/ContextVk.cpp

@@ -686,6 +686,9 @@ void ContextVk::syncState(const gl::Context *context, const gl::State::DirtyBits
             case gl::State::DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING:
                 WARN() << "DIRTY_BIT_DRAW_INDIRECT_BUFFER_BINDING unimplemented";
                 break;
+            case gl::State::DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING:
+                WARN() << "DIRTY_BIT_DISPATCH_INDIRECT_BUFFER_BINDING unimplemented";
+                break;
             case gl::State::DIRTY_BIT_PROGRAM_BINDING:
                 WARN() << "DIRTY_BIT_PROGRAM_BINDING unimplemented";
                 break;

src/tests/deqp_support/deqp_gles31_test_expectations.txt

@@ -1215,7 +1215,6 @@
 1442 OPENGL D3D11 : dEQP-GLES31.functional.stencil_texturing.render.depth24_stencil8_draw = FAIL
 1442 OPENGL D3D11 : dEQP-GLES31.functional.stencil_texturing.misc.compare_mode_effect = FAIL
 1442 OPENGL D3D11 : dEQP-GLES31.functional.stencil_texturing.misc.base_level = FAIL
-1442 OPENGL D3D11 : dEQP-GLES31.functional.state_query.integer.dispatch_indirect_buffer_binding_* = FAIL
 1442 OPENGL D3D11 : dEQP-GLES31.functional.state_query.integer.program_pipeline_binding_* = FAIL
 1442 OPENGL D3D11 : dEQP-GLES31.functional.state_query.indexed.image_binding* = FAIL
 1442 OPENGL D3D11 : dEQP-GLES31.functional.state_query.texture.texture_2d.depth_stencil_mode_* = FAIL