Commit aad69df9 by Jamie Madill Committed by Commit Bot

Run TracePerfTests in WGL configs.

Uses the "native" naming pattern. Bug: angleproject:4728 Change-Id: I28cafcdb8c5c1fb48bba51adeca641e88bfe3446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2241619Reviewed-by: 's avatarYuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent c39d25ae
...@@ -348,12 +348,10 @@ std::string RenderTestParams::backend() const ...@@ -348,12 +348,10 @@ std::string RenderTestParams::backend() const
{ {
case angle::GLESDriverType::AngleEGL: case angle::GLESDriverType::AngleEGL:
break; break;
case angle::GLESDriverType::SystemWGL:
case angle::GLESDriverType::SystemEGL: case angle::GLESDriverType::SystemEGL:
strstr << "_native"; strstr << "_native";
break; break;
case angle::GLESDriverType::SystemWGL:
strstr << "_wgl";
break;
default: default:
assert(0); assert(0);
return "_unk"; return "_unk";
......
...@@ -85,6 +85,16 @@ ParamsT EGL(const ParamsT &in) ...@@ -85,6 +85,16 @@ ParamsT EGL(const ParamsT &in)
out.driver = angle::GLESDriverType::SystemEGL; out.driver = angle::GLESDriverType::SystemEGL;
return out; return out;
} }
template <typename ParamsT>
ParamsT Native(const ParamsT &in)
{
#if defined(ANGLE_PLATFORM_WINDOWS)
return WGL(in);
#else
return EGL(in);
#endif
}
} // namespace params } // namespace params
#endif // TESTS_PERF_TESTS_DRAW_CALL_PERF_PARAMS_H_ #endif // TESTS_PERF_TESTS_DRAW_CALL_PERF_PARAMS_H_
...@@ -104,10 +104,18 @@ class TracePerfTest : public ANGLERenderTest, public ::testing::WithParamInterfa ...@@ -104,10 +104,18 @@ class TracePerfTest : public ANGLERenderTest, public ::testing::WithParamInterfa
TracePerfTest::TracePerfTest() TracePerfTest::TracePerfTest()
: ANGLERenderTest("TracePerf", GetParam()), mStartFrame(0), mEndFrame(0) : ANGLERenderTest("TracePerf", GetParam()), mStartFrame(0), mEndFrame(0)
{ {
// TODO(anglebug.com/4533) This fails after the upgrade to the 26.20.100.7870 driver. const TracePerfParams &param = GetParam();
if (IsWindows() && IsIntel() &&
GetParam().getRenderer() == EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE && // TODO: http://anglebug.com/4533 This fails after the upgrade to the 26.20.100.7870 driver.
GetParam().testID == RestrictedTraceID::manhattan_10) if (IsWindows() && IsIntel() && param.getRenderer() == EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE &&
param.testID == RestrictedTraceID::manhattan_10)
{
mSkipTest = true;
}
// TODO: http://anglebug.com/4731 Fails on older Intel drivers. Passes in newer.
if (IsWindows() && IsIntel() && param.driver != GLESDriverType::AngleEGL &&
param.testID == RestrictedTraceID::angry_birds_2_1500)
{ {
mSkipTest = true; mSkipTest = true;
} }
...@@ -361,7 +369,7 @@ using P = TracePerfParams; ...@@ -361,7 +369,7 @@ using P = TracePerfParams;
std::vector<P> gTestsWithID = std::vector<P> gTestsWithID =
CombineWithValues({P()}, AllEnums<RestrictedTraceID>(), CombineTestID); CombineWithValues({P()}, AllEnums<RestrictedTraceID>(), CombineTestID);
std::vector<P> gTestsWithRenderer = CombineWithFuncs(gTestsWithID, {Vulkan<P>, EGL<P>}); std::vector<P> gTestsWithRenderer = CombineWithFuncs(gTestsWithID, {Vulkan<P>, Native<P>});
ANGLE_INSTANTIATE_TEST_ARRAY(TracePerfTest, gTestsWithRenderer); ANGLE_INSTANTIATE_TEST_ARRAY(TracePerfTest, gTestsWithRenderer);
} // anonymous namespace } // anonymous namespace
...@@ -77,6 +77,7 @@ bool WGLWindow::initializeGL(OSWindow *osWindow, ...@@ -77,6 +77,7 @@ bool WGLWindow::initializeGL(OSWindow *osWindow,
{ {
if (driverType != angle::GLESDriverType::SystemWGL) if (driverType != angle::GLESDriverType::SystemWGL)
{ {
std::cerr << "WGLWindow requires angle::GLESDriverType::SystemWGL.\n";
return false; return false;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment