Skip to content

A
angle
Commit abd31359 by Jamie Madill Committed by Commit Bot
Options

Vulkan: Fix deleting in-use Pipeline.

This warning was popping up with a new version of the layers when running the hello_triangle sample. Fix it by assigning the current Serial ID to the Context for the current pipeline. A more robust fix in the future would probably be to assign Serial IDs to the Pipelines themselves. BUG=angleproject:1898 Change-Id: Ib5e8ea7c4c26907d1987529d8127249f9b18e17f Reviewed-on: https://chromium-review.googlesource.com/672146Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 0f80ed86
Showing with 2 additions and 0 deletions
src/libANGLE/renderer/vulkan/ContextVk.cpp
...@@ -320,6 +320,8 @@ gl::Error ContextVk::drawArrays(const gl::Context *context, GLenum mode, GLint f ...@@ -320,6 +320,8 @@ gl::Error ContextVk::drawArrays(const gl::Context *context, GLenum mode, GLint f
ANGLE_TRY(vkFBO->beginRenderPass(context, device, commandBuffer, queueSerial, state)); ANGLE_TRY(vkFBO->beginRenderPass(context, device, commandBuffer, queueSerial, state));
commandBuffer->bindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, mCurrentPipeline); commandBuffer->bindPipeline(VK_PIPELINE_BIND_POINT_GRAPHICS, mCurrentPipeline);
// TODO(jmadill): the queue serial should be bound to the pipeline.
setQueueSerial(queueSerial);
commandBuffer->bindVertexBuffers(0, vertexHandles, vertexOffsets); commandBuffer->bindVertexBuffers(0, vertexHandles, vertexOffsets);
commandBuffer->draw(count, 1, first, 0); commandBuffer->draw(count, 1, first, 0);
commandBuffer->endRenderPass(); commandBuffer->endRenderPass();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment