Capture: Disable GL_CHROMIUM_bind_uniform_location

Some apps (possibly those that use Skia) use the extension GL_CHROMIUM_bind_uniform_location, which is implemented by ANGLE. This leads to traces that contain calls to functions from this extension, such as: glBindUniformLocationCHROMIUM. Such traces do not replay on native GLES drivers, as the extension is not available. The fix is to disable the GL_CHROMIUM_bind_uniform_location extension when capturing, so that apps do not use this extension. Bug: b/174256233 Change-Id: I8c6de9dc958147bcad053cbf89d8727b40f45fbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2574836 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Capture: Disable GL_CHROMIUM_bind_uniform_location
abee60f6 · Paul Thomson · Commit Bot · f42409e6 · abee60f6
Commit abee60f6 authored Nov 30, 2020 by Paul Thomson Committed by Commit Bot Dec 04, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

Context.cpp src/libANGLE/Context.cpp +5 -0

No files found.
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -3568,6 +3568,11 @@ void Context::initCaps()
               << std::endl;
        mState.mExtensions.mapBufferRange = false;
        mState.mExtensions.mapBufferOES   = false;
+
+        INFO() << "Disabling GL_CHROMIUM_bind_uniform_location during capture, which is not "
+                  "supported on native drivers"
+               << std::endl;
+        mState.mExtensions.bindUniformLocation = false;
    }

    // Disable support for OES_get_program_binary