Commit ac59273c by Jamie Madill

Clean up Adapter LUID queries.

We might need to revisit this when we implement other GL back-ends. BUG=angle:773 Change-Id: I6e742254bd0df8cc899ea02a523992b4d66dfd68 Reviewed-on: https://chromium-review.googlesource.com/229061Tested-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarKenneth Russell <kbr@chromium.org> Reviewed-by: 's avatarBrandon Jones <bajones@chromium.org>
parent 8bc361e1
...@@ -739,15 +739,10 @@ void Display::initVendorString() ...@@ -739,15 +739,10 @@ void Display::initVendorString()
{ {
mVendorString = "Google Inc."; mVendorString = "Google Inc.";
LUID adapterLuid = {0}; // TODO(jmadill): clean this up
if (mRenderer)
//TODO(jmadill): LUID is not cross-platform
if (mRenderer && mRenderer->getLUID(&adapterLuid))
{ {
char adapterLuidString[64]; mVendorString += " " + mRenderer->getVendorString();
sprintf_s(adapterLuidString, sizeof(adapterLuidString), " (adapter LUID: %08x%08x)", adapterLuid.HighPart, adapterLuid.LowPart);
mVendorString += adapterLuidString;
} }
} }
......
...@@ -152,11 +152,12 @@ class Renderer ...@@ -152,11 +152,12 @@ class Renderer
virtual const gl::Extensions &getRendererExtensions() const; virtual const gl::Extensions &getRendererExtensions() const;
const Workarounds &getWorkarounds() const; const Workarounds &getWorkarounds() const;
virtual std::string getVendorString() const = 0;
// TODO(jmadill): needed by egl::Display, probably should be removed // TODO(jmadill): needed by egl::Display, probably should be removed
virtual int getMajorShaderModel() const = 0; virtual int getMajorShaderModel() const = 0;
virtual int getMinSwapInterval() const = 0; virtual int getMinSwapInterval() const = 0;
virtual int getMaxSwapInterval() const = 0; virtual int getMaxSwapInterval() const = 0;
virtual bool getLUID(LUID *adapterLuid) const = 0;
private: private:
DISALLOW_COPY_AND_ASSIGN(Renderer); DISALLOW_COPY_AND_ASSIGN(Renderer);
......
...@@ -811,4 +811,18 @@ void RendererD3D::notifyDeviceLost() ...@@ -811,4 +811,18 @@ void RendererD3D::notifyDeviceLost()
mDisplay->notifyDeviceLost(); mDisplay->notifyDeviceLost();
} }
std::string RendererD3D::getVendorString() const
{
LUID adapterLuid = { 0 };
if (getLUID(&adapterLuid))
{
char adapterLuidString[64];
sprintf_s(adapterLuidString, sizeof(adapterLuidString), "(adapter LUID: %08x%08x)", adapterLuid.HighPart, adapterLuid.LowPart);
return std::string(adapterLuidString);
}
return std::string("");
}
} }
...@@ -67,6 +67,7 @@ class RendererD3D : public Renderer ...@@ -67,6 +67,7 @@ class RendererD3D : public Renderer
GLbitfield mask, GLenum filter) override; GLbitfield mask, GLenum filter) override;
bool isDeviceLost() const override; bool isDeviceLost() const override;
std::string getVendorString() const override;
// Direct3D Specific methods // Direct3D Specific methods
virtual GUID getAdapterIdentifier() const = 0; virtual GUID getAdapterIdentifier() const = 0;
...@@ -166,6 +167,8 @@ class RendererD3D : public Renderer ...@@ -166,6 +167,8 @@ class RendererD3D : public Renderer
const gl::Rectangle *scissor, bool blitRenderTarget, const gl::Rectangle *scissor, bool blitRenderTarget,
bool blitDepth, bool blitStencil, GLenum filter) = 0; bool blitDepth, bool blitStencil, GLenum filter) = 0;
virtual bool getLUID(LUID *adapterLuid) const = 0;
void cleanup(); void cleanup();
egl::Display *mDisplay; egl::Display *mDisplay;
......
...@@ -203,7 +203,7 @@ class Renderer11 : public RendererD3D ...@@ -203,7 +203,7 @@ class Renderer11 : public RendererD3D
void setOneTimeRenderTarget(ID3D11RenderTargetView *renderTargetView); void setOneTimeRenderTarget(ID3D11RenderTargetView *renderTargetView);
gl::Error packPixels(ID3D11Texture2D *readTexture, const PackPixelsParams &params, uint8_t *pixelsOut); gl::Error packPixels(ID3D11Texture2D *readTexture, const PackPixelsParams &params, uint8_t *pixelsOut);
virtual bool getLUID(LUID *adapterLuid) const; bool getLUID(LUID *adapterLuid) const override;
virtual VertexConversionType getVertexConversionType(const gl::VertexFormat &vertexFormat) const; virtual VertexConversionType getVertexConversionType(const gl::VertexFormat &vertexFormat) const;
virtual GLenum getVertexComponentType(const gl::VertexFormat &vertexFormat) const; virtual GLenum getVertexComponentType(const gl::VertexFormat &vertexFormat) const;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment