Commit ae6c2b88 by Ian Elliott Committed by Commit Bot

Fixes found while turning on A4A opt-in/out code.

Bug: angleproject:2789 Change-Id: If9d83dd94d392103ed5200ba471d47dc907cf3ca Reviewed-on: https://chromium-review.googlesource.com/1194612Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent a7f97a27
...@@ -39,7 +39,7 @@ class VulkanLibrary final : NonCopyable ...@@ -39,7 +39,7 @@ class VulkanLibrary final : NonCopyable
VkInstance getVulkanInstance() VkInstance getVulkanInstance()
{ {
// Find the system's Vulkan library and open it: // Find the system's Vulkan library and open it:
mLibVulkan = dlopen("mLibVulkan.so", RTLD_NOW | RTLD_LOCAL); mLibVulkan = dlopen("libvulkan.so", RTLD_NOW | RTLD_LOCAL);
if (!mLibVulkan) if (!mLibVulkan)
{ {
// If Vulkan doesn't exist, bail-out early: // If Vulkan doesn't exist, bail-out early:
...@@ -50,7 +50,8 @@ class VulkanLibrary final : NonCopyable ...@@ -50,7 +50,8 @@ class VulkanLibrary final : NonCopyable
uint32_t instanceVersion = VK_API_VERSION_1_0; uint32_t instanceVersion = VK_API_VERSION_1_0;
#if defined(VK_VERSION_1_1) #if defined(VK_VERSION_1_1)
PFN_vkEnumerateInstanceVersion pfnEnumerateInstanceVersion = PFN_vkEnumerateInstanceVersion pfnEnumerateInstanceVersion =
reinterpret_cast<PFN_vkCreateInstance>(dlsym(mLibVulkan, "vkEnumerateInstanceVersion")); reinterpret_cast<PFN_vkEnumerateInstanceVersion>(
dlsym(mLibVulkan, "vkEnumerateInstanceVersion"));
if (!pfnEnumerateInstanceVersion || if (!pfnEnumerateInstanceVersion ||
pfnEnumerateInstanceVersion(&instanceVersion) != VK_SUCCESS) pfnEnumerateInstanceVersion(&instanceVersion) != VK_SUCCESS)
{ {
...@@ -128,7 +129,6 @@ bool GetSystemInfo(SystemInfo *info) ...@@ -128,7 +129,6 @@ bool GetSystemInfo(SystemInfo *info)
PFN_vkGetPhysicalDeviceProperties pfnGetPhysicalDeviceProperties = PFN_vkGetPhysicalDeviceProperties pfnGetPhysicalDeviceProperties =
GPA(vkLibrary, PFN_vkGetPhysicalDeviceProperties, "vkGetPhysicalDeviceProperties"); GPA(vkLibrary, PFN_vkGetPhysicalDeviceProperties, "vkGetPhysicalDeviceProperties");
uint32_t physicalDeviceCount = 0; uint32_t physicalDeviceCount = 0;
VkPhysicalDevice *pPhysicalDevices = nullptr;
if (!pfnEnumeratePhysicalDevices || if (!pfnEnumeratePhysicalDevices ||
pfnEnumeratePhysicalDevices(instance, &physicalDeviceCount, nullptr) != VK_SUCCESS) pfnEnumeratePhysicalDevices(instance, &physicalDeviceCount, nullptr) != VK_SUCCESS)
{ {
...@@ -147,7 +147,7 @@ bool GetSystemInfo(SystemInfo *info) ...@@ -147,7 +147,7 @@ bool GetSystemInfo(SystemInfo *info)
for (uint32_t i = 0; i < physicalDeviceCount; i++) for (uint32_t i = 0; i < physicalDeviceCount; i++)
{ {
VkPhysicalDeviceProperties properties; VkPhysicalDeviceProperties properties;
pfnGetPhysicalDeviceProperties(pPhysicalDevices[i], &properties); pfnGetPhysicalDeviceProperties(physicalDevices[i], &properties);
// Fill in data for a given physical device (a.k.a. gpu): // Fill in data for a given physical device (a.k.a. gpu):
GPUDeviceInfo &gpu = info->gpus[i]; GPUDeviceInfo &gpu = info->gpus[i];
gpu.vendorId = properties.vendorID; gpu.vendorId = properties.vendorID;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment