Fix stale validation cache on buffer deletion.

When we would delete the currently bound element array buffer we would neglect to invalidate a specific validation cache variable. This incorrectly would let us skip buffer size validation and lead to internal invalid memory accesses. Bug: chromium:1105202 Change-Id: I23ab28ccd3ac6b5d461cb8745b930f4d42d53b35 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2323644Reviewed-by: Jamie Madill <jmadill@chromium.org>

Fix stale validation cache on buffer deletion.
af5b008a · Jamie Madill · d188231d · af5b008a · af5b008a
Commit af5b008a authored Jul 14, 2020 by Jamie Madill
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

Context.cpp src/libANGLE/Context.cpp +1 -0

Context.h src/libANGLE/Context.h +1 -0

No files found.
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -8646,6 +8646,7 @@ void StateCache::onVertexArrayStateChange(Context *context)
    updateActiveAttribsMask(context);
    updateVertexElementLimits(context);
    updateBasicDrawStatesError();
+    updateBasicDrawElementsError();
 }

 void StateCache::onVertexArrayBufferStateChange(Context *context)

--- a/src/libANGLE/Context.h
+++ b/src/libANGLE/Context.h
@@ -202,6 +202,7 @@ class StateCache final : angle::NonCopyable
    // 1. onActiveTransformFeedbackChange.
    // 2. onVertexArrayBufferStateChange.
    // 3. onBufferBindingChange.
+    // 4. onVertexArrayStateChange.
    intptr_t getBasicDrawElementsError(const Context *context) const
    {
        if (mCachedBasicDrawElementsError != kInvalidPointer)