Handle nullptr mSwapChain in SwapChain11::getSyncValues

There are 6 crashes in SwapChain11::getSyncValues on crash server. I looked at one of them and it is due to a nullptr mSwapChain which appears to be a valid state that is handled in other SwapChain11 methods. This change adds a similar check / returning an error to SwapChain11::getSyncValues. BUG=angleproject:1402 Change-Id: I9c17b884704b8aaaddf2d802911cd0ca961ae0b4 Reviewed-on: https://chromium-review.googlesource.com/402613Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org>

Handle nullptr mSwapChain in SwapChain11::getSyncValues
af7f301f · Stanislav Chiknavaryan · Commit Bot · 81c6b577 · af7f301f
Commit af7f301f authored Oct 24, 2016 by Stanislav Chiknavaryan Committed by Commit Bot Oct 25, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

SwapChain11.cpp src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp +5 -0

No files found.
--- a/src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp
+++ b/src/libANGLE/renderer/d3d/d3d11/SwapChain11.cpp
@@ -893,6 +893,11 @@ void SwapChain11::recreate()

 egl::Error SwapChain11::getSyncValues(EGLuint64KHR *ust, EGLuint64KHR *msc, EGLuint64KHR *sbc)
 {
+    if (!mSwapChain)
+    {
+        return egl::Error(EGL_NOT_INITIALIZED, "Swap chain uninitialized");
+    }
+
    DXGI_FRAME_STATISTICS stats = {};
    HRESULT result              = mSwapChain->GetFrameStatistics(&stats);