Commit af98f24a by Corentin Wallez

EGLContextCompatibility: suppress test on Linux non-standalone

The tests turn out to fail before we have a context current on AMD so we cannot use isAMD and have to resort to disabling for all Linuxes on the FYI bots. Using MAYBE like Chrome doesn't seem to work with TEST_P. BUG=angleproject:892 Change-Id: Ie964168eb0b1d830dd1fd0988869adf39bc2309a Reviewed-on: https://chromium-review.googlesource.com/284872Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Tested-by: 's avatarCorentin Wallez <cwallez@chromium.org>
parent 01971113
...@@ -53,6 +53,13 @@ ...@@ -53,6 +53,13 @@
'<(windows_sdk_path)/Include/um', '<(windows_sdk_path)/Include/um',
], ],
}], }],
['angle_standalone==1',
{
'defines':
[
'ANGLE_STANDALONE_BUILD',
],
}],
], ],
'msvs_settings': 'msvs_settings':
{ {
......
...@@ -175,15 +175,6 @@ class EGLContextCompatibilityTest : public ANGLETest ...@@ -175,15 +175,6 @@ class EGLContextCompatibilityTest : public ANGLETest
eglMakeCurrent(mDisplay, surface, surface, context); eglMakeCurrent(mDisplay, surface, surface, context);
ASSERT_EGL_SUCCESS(); ASSERT_EGL_SUCCESS();
#ifdef ANGLE_PLATFORM_LINUX
// TODO(cwallez): figure out why this is broken on Linux/AMD.
if (isAMD() && getPlatformRenderer() == EGL_PLATFORM_ANGLE_TYPE_OPENGL_ANGLE)
{
eglMakeCurrent(mDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);
return;
}
#endif
glViewport(0, 0, 500, 500); glViewport(0, 0, 500, 500);
glClearColor(0.0f, 0.0f, 1.0f, 1.0f); glClearColor(0.0f, 0.0f, 1.0f, 1.0f);
glClear(GL_COLOR_BUFFER_BIT); glClear(GL_COLOR_BUFFER_BIT);
...@@ -201,6 +192,9 @@ class EGLContextCompatibilityTest : public ANGLETest ...@@ -201,6 +192,9 @@ class EGLContextCompatibilityTest : public ANGLETest
} }
}; };
// TODO(cwallez) makeCurrent fails for some config on Linux/AMD
#if !defined(ANGLE_PLATFORM_LINUX) || defined(ANGLE_STANDALONE_BUILD)
// The test is split in several subtest so that simple cases // The test is split in several subtest so that simple cases
// are tested separately. Also each surface types are not tested // are tested separately. Also each surface types are not tested
// together. // together.
...@@ -291,4 +285,6 @@ TEST_P(EGLContextCompatibilityTest, PbufferDifferentConfig) ...@@ -291,4 +285,6 @@ TEST_P(EGLContextCompatibilityTest, PbufferDifferentConfig)
} }
} }
#endif // !defined(ANGLE_PLATFORM_LINUX) || defined(ANGLE_STANDALONE_BUILD)
ANGLE_INSTANTIATE_TEST(EGLContextCompatibilityTest, ES2_D3D9(), ES2_D3D11(), ES2_OPENGL()); ANGLE_INSTANTIATE_TEST(EGLContextCompatibilityTest, ES2_D3D9(), ES2_D3D11(), ES2_OPENGL());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment