Compiler: avoid an undefined behavior when using erase-remove

Using that idiom on an empty vector results in an undefined behavior that I have seen cause a vector to get length -1 with clang 3.6 on Linux. BUG= Change-Id: I3bb8d8884efa29a17672b458263067644dbf0fec Reviewed-on: https://chromium-review.googlesource.com/286740Reviewed-by: Jamie Madill <jmadill@chromium.org> Tested-by: Corentin Wallez <cwallez@chromium.org>

Compiler: avoid an undefined behavior when using erase-remove
b081e78b · Corentin Wallez · a455824c · b081e78b
Commit b081e78b authored Jul 20, 2015 by Corentin Wallez
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

Compiler.cpp src/compiler/translator/Compiler.cpp +5 -1

No files found.
--- a/src/compiler/translator/Compiler.cpp
+++ b/src/compiler/translator/Compiler.cpp
@@ -649,7 +649,11 @@ bool TCompiler::pruneUnusedFunctions(TIntermNode *root)

    UnusedPredicate isUnused(&mCallDag, &functionMetadata);
    TIntermSequence *sequence = rootNode->getSequence();
-    sequence->erase(std::remove_if(sequence->begin(), sequence->end(), isUnused), sequence->end());
+
+    if (!sequence->empty())
+    {
+        sequence->erase(std::remove_if(sequence->begin(), sequence->end(), isUnused), sequence->end());
+    }

    return true;
 }