Disable GL_EXT_shader_framebuffer_fetch_non_coherent on Arm/QCOM

Thie is a shorter-term work-around to games not checking extensions properly. Bug: b/177320565 Bug: b/186643966 Bug: b/186783762 Change-Id: Ic348396db1d081925cd9747cdd9406f5929313b9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894407Reviewed-by: Charlie Lao <cclao@google.com> Reviewed-by: Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>

Disable GL_EXT_shader_framebuffer_fetch_non_coherent on Arm/QCOM
b0c217ba · Ian Elliott · Commit Bot · e601181d · b0c217ba
Commit b0c217ba authored May 13, 2021 by Ian Elliott Committed by Commit Bot May 13, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 4 deletions

vk_caps_utils.cpp src/libANGLE/renderer/vulkan/vk_caps_utils.cpp +12 -4

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_caps_utils.cpp
@@ -874,10 +874,18 @@ void RendererVk::ensureCapsInitialized() const
    mNativeCaps.subPixelBits = limitsVk.subPixelPrecisionBits;
-    // Enable GL_EXT_shader_framebuffer_fetch_non_coherent
+    // Important games are not checking supported extensions properly, and are confusing the
-    // For supporting this extension, gl::IMPLEMENTATION_MAX_DRAW_BUFFERS is used.
+    // GL_EXT_shader_framebuffer_fetch_non_coherent as the GL_EXT_shader_framebuffer_fetch
-    mNativeExtensions.shaderFramebufferFetchNonCoherentEXT =
+    // extension.  Therefore, don't enable the extension on Arm and Qualcomm.
-        mNativeCaps.maxDrawBuffers >= gl::IMPLEMENTATION_MAX_DRAW_BUFFERS;
+    // https://issuetracker.google.com/issues/186643966
+    if (!(IsARM(mPhysicalDeviceProperties.vendorID) ||
+          IsQualcomm(mPhysicalDeviceProperties.vendorID)))
+    {
+        // Enable GL_EXT_shader_framebuffer_fetch_non_coherent
+        // For supporting this extension, gl::IMPLEMENTATION_MAX_DRAW_BUFFERS is used.
+        mNativeExtensions.shaderFramebufferFetchNonCoherentEXT =
+            mNativeCaps.maxDrawBuffers >= gl::IMPLEMENTATION_MAX_DRAW_BUFFERS;
+    }
    // Enable Program Binary extension.
    mNativeExtensions.getProgramBinaryOES = true;