Skip to content

A
angle
Commit b13c38c1 by Ian Elliott Committed by Commit Bot
Options

Vulkan: Enable GL_UNPACK_SKIP_IMAGES in the Tex*Image* code

A boolean was hard-coded to false to disable the use of GL_UNPACK_SKIP_IMAGES disabled in ImageHelper::stageSubresourceUpdate() (I assume because 3D textures wasn't yet supported). The boolean is now set based on type type of the texture. Bug: angleproject:3781 Change-Id: I09d9fd142cceb3bebfa341fd0ff9179241c61a9c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1738433Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Ian Elliott <ianelliott@google.com>
parent 0296e169
Showing with 1 addition and 13 deletions
src/libANGLE/renderer/vulkan/vk_helpers.cpp
......@@ -2081,12 +2081,10 @@ angle::Result ImageHelper::stageSubresourceUpdate(ContextVk *contextVk,
contextVk, formatInfo.computeDepthPitch(glExtents.height, unpack.imageHeight, inputRowPitch,
&inputDepthPitch));
bool applySkipImages = false;
GLuint inputSkipBytes = 0;
ANGLE_VK_CHECK_MATH(contextVk,
formatInfo.computeSkipBytes(type, inputRowPitch, inputDepthPitch, unpack,
applySkipImages, &inputSkipBytes));
index.usesTex3D(), &inputSkipBytes));
const angle::Format &storageFormat = vkFormat.imageFormat();
......
src/tests/deqp_support/deqp_gles3_test_expectations.txt
......@@ -548,16 +548,6 @@
3190 VULKAN PIXEL2 : dEQP-GLES3.functional.texture.specification.texstorage3d.format.rgb16* = FAIL
3190 VULKAN PIXEL2 : dEQP-GLES3.functional.texture.specification.texstorage3d.format.rg32* = FAIL
// Pixel pack/unpack settings:
3209 VULKAN : dEQP-GLES3.functional.texture.specification.teximage3d_unpack_params.rgb8_skip_images = FAIL
3209 VULKAN : dEQP-GLES3.functional.texture.specification.texsubimage3d_unpack_params.rgb8_skip_images = FAIL
3209 VULKAN : dEQP-GLES3.functional.texture.specification.teximage3d_unpack_params.r8_* = FAIL
3209 VULKAN : dEQP-GLES3.functional.texture.specification.texsubimage3d_unpack_params.r8_* = FAIL
// Pixel Buffer Objects (PBOs):
3209 VULKAN : dEQP-GLES3.functional.texture.specification.teximage3d_pbo.rgb8_skip_images* = FAIL
3209 VULKAN : dEQP-GLES3.functional.texture.specification.texsubimage3d_pbo.rgb8_skip_images* = FAIL
// Formats:
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba32f = FAIL
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.rgba32f = FAIL
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment