Vulkan: damage rectangles must never be pre-rotated

include/platform/FeaturesVk.h

@@ -90,16 +90,6 @@ struct FeaturesVk : FeatureSetBase
         "supportsIncrementalPresent", FeatureCategory::VulkanFeatures,
         "VkDevice supports the VK_KHR_incremental_present extension", &members};
 
-    // Whether the Vulkan presentation engine rotates the present region rectangles of the
-    // VK_KHR_incremental_present extension in pre-rotation situations.  The Android presentation
-    // engine assumes that these rectangles need to be rotated, and thus ANGLE should not also
-    // pre-rotate them.
-    Feature disablePreRotateIncrementalPresentRectangles = {
-        "disablePreRotateIncrementalPresentRectangles", FeatureCategory::VulkanFeatures,
-        "Presentation engine performs necessary rotation for present region rectangles of the "
-        "VK_KHR_incremental_present extension",
-        &members};
-
     // Whether texture copies on cube map targets should be done on GPU.  This is a workaround for
     // Intel drivers on windows that have an issue with creating single-layer views on cube map
     // textures.

src/libANGLE/renderer/vulkan/RendererVk.cpp

@@ -2132,13 +2132,6 @@ void RendererVk::initFeatures(DisplayVk *displayVk,
         &mFeatures, supportsIncrementalPresent,
         ExtensionFound(VK_KHR_INCREMENTAL_PRESENT_EXTENSION_NAME, deviceExtensionNames));
 
-    // The Vulkan specification for the VK_KHR_incremental_present extension does not address
-    // rotation.  In Android, this extension is implemented on top of the same platform code as
-    // eglSwapBuffersWithDamageKHR(), which code assumes that it should rotate each rectangle.  To
-    // avoid double-rotating damage rectangles on Android, we must avoid pre-rotating
-    // application-provided rectangles.   See: https://issuetracker.google.com/issues/181796746
-    ANGLE_FEATURE_CONDITION(&mFeatures, disablePreRotateIncrementalPresentRectangles, IsAndroid());
-
 #if defined(ANGLE_PLATFORM_ANDROID)
     ANGLE_FEATURE_CONDITION(
         &mFeatures, supportsAndroidHardwareBuffer,

src/libANGLE/renderer/vulkan/SurfaceVk.cpp

@@ -1421,12 +1421,7 @@ angle::Result WindowSurfaceVk::present(ContextVk *contextVk,
             rect.extent.width  = gl::clamp(*eglRects++, 0, width - rect.offset.x);
             rect.extent.height = gl::clamp(*eglRects++, 0, height - rect.offset.y);
             rect.layer         = 0;
-            if (Is90DegreeRotation(getPreTransform()) &&
-                !contextVk->getFeatures().disablePreRotateIncrementalPresentRectangles.enabled)
-            {
-                std::swap(rect.offset.x, rect.offset.y);
-                std::swap(rect.extent.width, rect.extent.height);
-            }
+            // No rotation is done to these damage rectangles per the Vulkan spec.
         }
         presentRegion.pRectangles = vkRects.data();