Skip to content

A
angle
Commit b31f35ab by daniel@transgaming.com
Options

Fix invalid compare operation asserts.

TRAC #15551 Issue=116 Signed-off-by: Daniel Koch Author: Nicolas Capens git-svn-id: https://angleproject.googlecode.com/svn/trunk@559 736b8ea6-26fd-11df-bfd4-992fa37f6226
parent 721b7f26
Showing with 6 additions and 20 deletions
src/compiler/ConstantUnion.h
...@@ -99,18 +99,11 @@ public: ...@@ -99,18 +99,11 @@ public:
assert(type == constant.type); assert(type == constant.type);
switch (type) { switch (type) {
case EbtInt: case EbtInt:
if (iConst > constant.iConst) return iConst > constant.iConst;
return true;
return false;
case EbtFloat: case EbtFloat:
if (fConst > constant.fConst) return fConst > constant.fConst;
return true;
return false;
default: default:
assert(false && "Default missing"); return false; // Invalid operation, handled at semantic analysis
return false;
} }
return false; return false;
...@@ -121,18 +114,11 @@ public: ...@@ -121,18 +114,11 @@ public:
assert(type == constant.type); assert(type == constant.type);
switch (type) { switch (type) {
case EbtInt: case EbtInt:
if (iConst < constant.iConst) return iConst < constant.iConst;
return true;
return false;
case EbtFloat: case EbtFloat:
if (fConst < constant.fConst) return fConst < constant.fConst;
return true;
return false;
default: default:
assert(false && "Default missing"); return false; // Invalid operation, handled at semantic analysis
return false;
} }
return false; return false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment