Commit b3280707 by Yuly Novikov Committed by Commit Bot

Change ERR to WARN in RendererD3D::skipDraw

For undefined behavior when point rendering without writing to gl_PointSize. Even the comment used to say "This is stictly speaking not an error". BUG=angleproject:1660 Change-Id: Ic8b33689151c9812592dd6b22c83a3355b7d6756 Reviewed-on: https://chromium-review.googlesource.com/437746Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 72e27b02
...@@ -182,10 +182,8 @@ bool RendererD3D::skipDraw(const gl::ContextState &data, GLenum drawMode) ...@@ -182,10 +182,8 @@ bool RendererD3D::skipDraw(const gl::ContextState &data, GLenum drawMode)
// undefined when not written, just skip drawing to avoid unexpected results. // undefined when not written, just skip drawing to avoid unexpected results.
if (!usesPointSize && !state.isTransformFeedbackActiveUnpaused()) if (!usesPointSize && !state.isTransformFeedbackActiveUnpaused())
{ {
// This is stictly speaking not an error, but developers should be // Notify developers of risking undefined behavior.
// notified of risking undefined behavior. WARN() << "Point rendering without writing to gl_PointSize.";
ERR() << "Point rendering without writing to gl_PointSize.";
return true; return true;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment