Commit b33972d4 by Nico Weber Committed by Commit Bot

Fix MSan report in HandleAllocatorTest.Reallocation

[ RUN ] HandleAllocatorTest.Reallocation ==30439==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x1a11ef5 in gl::HandleAllocator::allocate() third_party/angle/src/libANGLE/HandleAllocator.cpp:83:9 #1 0x6643eb in (anonymous namespace)::HandleAllocatorTest_Reallocation_Test::TestBody() third_party/angle/src/libANGLE/HandleAllocator_unittest.cpp:75:42 Looks like a true positive, one of the ctors wasn't initializing a field. Change-Id: Id8a93fe6c9a6f1f01249235630981f4f0ac4a782 Reviewed-on: https://chromium-review.googlesource.com/987474 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
parent b1de5a7e
...@@ -30,7 +30,8 @@ HandleAllocator::HandleAllocator() : mBaseValue(1), mNextValue(1), mLoggingEnabl ...@@ -30,7 +30,8 @@ HandleAllocator::HandleAllocator() : mBaseValue(1), mNextValue(1), mLoggingEnabl
mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max())); mUnallocatedList.push_back(HandleRange(1, std::numeric_limits<GLuint>::max()));
} }
HandleAllocator::HandleAllocator(GLuint maximumHandleValue) : mBaseValue(1), mNextValue(1) HandleAllocator::HandleAllocator(GLuint maximumHandleValue)
: mBaseValue(1), mNextValue(1), mLoggingEnabled(false)
{ {
mUnallocatedList.push_back(HandleRange(1, maximumHandleValue)); mUnallocatedList.push_back(HandleRange(1, maximumHandleValue));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment