Capture/Replay: don't capture DrawElements with count zero

Usually Context::noopDraw would reject calls that doen't draw, but FrameCapture::maybeCaptureDrawElementsClientData seems to be called before Context::noopDraw, and since in ComputeTypedIndexRange we would obtain the illegal range [0,0) (which is actually prohibited by an ssertion "count > 0"), we have to exit early. With that the test can be enabled. Bug: angleproject:6111 Change-Id: I4c242712bd90602f84ad6072b02c3a13a26840f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2993089Reviewed-by: Cody Northrop <cnorthrop@google.com> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

Capture/Replay: don't capture DrawElements with count zero
b3e920e2 · Gert Wollny · Angle LUCI CQ · 5d314b59 · b3e920e2 · b3e920e2
Commit b3e920e2 authored Jun 28, 2021 by Gert Wollny Committed by Angle LUCI CQ Jul 07, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

FrameCapture.cpp src/libANGLE/capture/FrameCapture.cpp +7 -0

capture_replay_expectations.txt ...ests/capture_replay_tests/capture_replay_expectations.txt +0 -1

No files found.
--- a/src/libANGLE/capture/FrameCapture.cpp
+++ b/src/libANGLE/capture/FrameCapture.cpp
@@ -4076,7 +4076,14 @@ void FrameCapture::maybeCaptureDrawElementsClientData(const gl::Context *context
        return;
    }
+    // if the count is zero then the index evaluation is not valid and we wouldn't be drawing
+    // anything anyway, so skip capturing
    GLsizei count = call.params.getParam("count", ParamType::TGLsizei, 1).value.GLsizeiVal;
+    if (count == 0)
+    {
+        return;
+    }
    gl::DrawElementsType drawElementsType =
        call.params.getParam("typePacked", ParamType::TDrawElementsType, 2)
            .value.DrawElementsTypeVal;

--- a/src/tests/capture_replay_tests/capture_replay_expectations.txt
+++ b/src/tests/capture_replay_tests/capture_replay_expectations.txt
@@ -53,7 +53,6 @@ VertexAttributeTest.*
 ViewportTest.*
 VulkanExternalImageTest.*
-WebGLCompatibilityTest.NullIndexBuffer/*
 WebGLCompatibilityTest.EnableProgramBinaryExtension/*
 WebGLCompatibilityTest.MultiContextNoRenderingFeedbackLoops/*
 WebGLFramebufferTest.*