Vulkan: No need to unmap buffer when adding to mInFlightBuffers

When we move a BufferHelper to the mInFlightBuffers list don't try to unmap it there, instead do that when it gets added to mBufferFreeList This removes 0.75% CPU overhead from a Manhattan30 offscreen run Bug: angleproject:5689 Change-Id: I01a52cdf4803fb8364140b01bedbd3d0e6cc61fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2723492 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Vulkan: No need to unmap buffer when adding to mInFlightBuffers
b5af8bde · Mohan Maiya · Commit Bot · 46df78dc · b5af8bde
Commit b5af8bde authored Feb 24, 2021 by Mohan Maiya Committed by Commit Bot Feb 26, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

vk_helpers.cpp src/libANGLE/renderer/vulkan/vk_helpers.cpp +1 -1

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.cpp
@@ -1797,7 +1797,6 @@ angle::Result DynamicBuffer::allocateWithAlignment(ContextVk *contextVk,
        if (mBuffer)
        {
            ANGLE_TRY(flush(contextVk));
-            mBuffer->unmap(contextVk->getRenderer());

            mInFlightBuffers.push_back(std::move(mBuffer));
            ASSERT(!mBuffer);
@@ -1920,6 +1919,7 @@ void DynamicBuffer::releaseInFlightBuffersToResourceUseList(ContextVk *contextVk
        }
        else
        {
+            bufferHelper->unmap(contextVk->getRenderer());
            mBufferFreeList.push_back(std::move(bufferHelper));
        }
    }