Skip to content

A
angle
Commit b66de58f by Nico Weber Committed by Commit Bot
Options

Mark third-party code in ANGLE as no_chromium_code.

That way, we don't have to explicitly disable Wimplicit-fallthrough for these targets, and when we add new warnings to chromium_code in the future, these targets won't need any special attention. Like https://chromium-review.googlesource.com/c/chromium/src/+/905222 Bug: 807632 Change-Id: I3a605dd3ef9ed7d8cfe9e36964c3433040bfc330 Reviewed-on: https://chromium-review.googlesource.com/922503Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
parent d7ebfb92
Showing with 12 additions and 21 deletions
third_party/glslang/BUILD.gn
......@@ -25,10 +25,6 @@ config("glslang_internal_config") {
if (!is_clang && !is_win) {
cflags += [ "-Wno-unused-function" ]
}
if (is_clang) {
# TODO(thakis): Consider enabling this, https://crbug.com/807632
cflags += [ "-Wno-implicit-fallthrough" ]
}
}
static_library("glslang") {
......@@ -116,6 +112,8 @@ static_library("glslang") {
"src/glslang/Public/ShaderLang.h",
]
public_configs = [ ":glslang_config" ]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":glslang_internal_config" ]
if (is_win) {
......
third_party/spirv-tools/BUILD.gn
......@@ -147,13 +147,6 @@ config("spirv_tools_config") {
]
}
}
config("spirv_tools_internal_config") {
if (is_clang) {
# TODO(thakis): Consider enabling this, https://crbug.com/807632
cflags = [ "-Wno-implicit-fallthrough" ]
}
}
static_library("spirv_tools") {
deps = [
":spirv_tools_gen_core_tables_1.0",
......@@ -243,7 +236,8 @@ static_library("spirv_tools") {
"src/source/validate_type_unique.cpp",
]
public_configs = [ ":spirv_tools_config" ]
configs += [ ":spirv_tools_internal_config" ]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
foreach(target_name, spvtools_vendor_tables) {
deps += [ ":$target_name" ]
......
third_party/vulkan-validation-layers/BUILD.gn
......@@ -236,15 +236,6 @@ config("vulkan_internal_config") {
defines = [ "VULKAN_NON_CMAKE_BUILD" ]
if (is_clang || !is_win) {
cflags = [ "-Wno-unused-function" ]
cflags += [
# See https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/issues/1649
# TODO(jmadill): Lift this once github issue is fixed.
"-Wno-ignored-attributes",
# TODO(thakis): Consider enabling this, https://crbug.com/807632
"-Wno-implicit-fallthrough",
]
}
if (is_linux) {
defines += [
......@@ -328,6 +319,8 @@ if (!is_android) {
public_deps = [
":vulkan_headers",
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":vulkan_internal_config" ]
public_configs = [
":vulkan_config",
......@@ -354,6 +347,8 @@ source_set("vulkan_layer_table") {
":vulkan_layer_config",
":vulkan_internal_config",
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
sources = [
"$target_gen_dir/angle/vulkan/vk_dispatch_table_helper.h",
"$target_gen_dir/angle/vulkan/vk_enum_string_helper.h",
......@@ -542,6 +537,8 @@ source_set("vulkan_layer_utils") {
":vulkan_loader_config",
":vulkan_internal_config",
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
public_deps = [
":vulkan_generate_helper_files",
]
......@@ -594,6 +591,8 @@ source_set("vulkan_gen_parameter_validation") {
foreach(layer_info, layers) {
name = layer_info[0]
shared_library("VkLayer_$name") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs -= vulkan_undefine_configs
deps = [
":vulkan_layer_table",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment