Capture/Replay: Capture GetFloatv params.

src/libANGLE/FrameCapture.cpp

@@ -1215,6 +1215,21 @@ void CaptureString(const GLchar *str, ParamCapture *paramCapture)
     CaptureMemory(str, strlen(str) + 1, paramCapture);
 }
 
+void CaptureGetParameter(const gl::Context *context,
+                         GLenum pname,
+                         size_t typeSize,
+                         ParamCapture *paramCapture)
+{
+    GLenum nativeType;
+    unsigned int numParams;
+    if (!context->getQueryParameterInfo(pname, &nativeType, &numParams))
+    {
+        numParams = 1;
+    }
+
+    paramCapture->readBufferSizeBytes = typeSize * numParams;
+}
+
 void CaptureGenHandlesImpl(GLsizei n, GLuint *handles, ParamCapture *paramCapture)
 {
     paramCapture->readBufferSizeBytes = sizeof(GLuint) * n;

src/libANGLE/FrameCapture.h

@@ -245,6 +245,13 @@ std::ostream &operator<<(std::ostream &os, const ParamCapture &capture);
 // Pointer capture helpers.
 void CaptureMemory(const void *source, size_t size, ParamCapture *paramCapture);
 void CaptureString(const GLchar *str, ParamCapture *paramCapture);
+
+// For GetIntegerv, GetFloatv, etc.
+void CaptureGetParameter(const gl::Context *context,
+                         GLenum pname,
+                         size_t typeSize,
+                         ParamCapture *paramCapture);
+
 void CaptureGenHandlesImpl(GLsizei n, GLuint *handles, ParamCapture *paramCapture);
 
 template <typename T>

src/libANGLE/capture_gles_2_0_params.cpp

@@ -335,10 +335,7 @@ void CaptureGetBooleanv_data(const Context *context,
                              GLboolean *data,
                              ParamCapture *paramCapture)
 {
-    GLenum type;
-    unsigned int numParams;
-    context->getQueryParameterInfo(pname, &type, &numParams);
-    paramCapture->readBufferSizeBytes = sizeof(GLboolean) * numParams;
+    CaptureGetParameter(context, pname, sizeof(GLboolean), paramCapture);
 }
 
 void CaptureGetBufferParameteriv_params(const Context *context,
@@ -357,7 +354,7 @@ void CaptureGetFloatv_data(const Context *context,
                            GLfloat *data,
                            ParamCapture *paramCapture)
 {
-    UNIMPLEMENTED();
+    CaptureGetParameter(context, pname, sizeof(GLfloat), paramCapture);
 }
 
 void CaptureGetFramebufferAttachmentParameteriv_params(const Context *context,
@@ -378,10 +375,7 @@ void CaptureGetIntegerv_data(const Context *context,
                              GLint *data,
                              ParamCapture *paramCapture)
 {
-    GLenum type;
-    unsigned int numParams;
-    context->getQueryParameterInfo(pname, &type, &numParams);
-    paramCapture->readBufferSizeBytes = sizeof(GLint) * numParams;
+    CaptureGetParameter(context, pname, sizeof(GLint), paramCapture);
 }
 
 void CaptureGetProgramInfoLog_length(const Context *context,