Added runtime checks for GetClientRect errors.

I noticed that if the window handle is invalid, the resulting rect will be uninitialized. This change makes it fail immediately. Review URL: http://codereview.appspot.com/2009042 git-svn-id: https://angleproject.googlecode.com/svn/trunk@386 736b8ea6-26fd-11df-bfd4-992fa37f6226

Added runtime checks for GetClientRect errors.
b707a3b7 · apatrick@chromium.org · 32cfaf4b · b707a3b7
Commit b707a3b7 authored Aug 23, 2010 by apatrick@chromium.org
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 2 deletions

Surface.cpp src/libEGL/Surface.cpp +12 -2

No files found.
--- a/src/libEGL/Surface.cpp
+++ b/src/libEGL/Surface.cpp
@@ -92,7 +92,12 @@ void Surface::resetSwapChain()
    presentParameters.Windowed = TRUE;

    RECT windowRect;
-    GetClientRect(getWindowHandle(), &windowRect);
+    if (!GetClientRect(getWindowHandle(), &windowRect))
+    {
+        ASSERT(false);
+        return;
+    }
+
    presentParameters.BackBufferWidth = windowRect.right - windowRect.left;
    presentParameters.BackBufferHeight = windowRect.bottom - windowRect.top;

@@ -308,7 +313,12 @@ void Surface::releaseRecordedState(IDirect3DDevice9 *device)
 bool Surface::checkForWindowResize()
 {
    RECT client;
-    GetClientRect(getWindowHandle(), &client);
+    if (!GetClientRect(getWindowHandle(), &client))
+    {
+        ASSERT(false);
+        return false;
+    }
+
    if (getWidth() != client.right - client.left || getHeight() != client.bottom - client.top)
    {
        resetSwapChain();