Commit b8c0a832 by Shannon Woods

Amend comment about nameless structs & layout qualifiers

Change-Id: I1177c808bffd2beba7d52bd8f8869125a1624698 Reviewed-on: https://chromium-review.googlesource.com/212700Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Reviewed-by: 's avatarNicolas Capens <capn@chromium.org> Tested-by: 's avatarShannon Woods <shannonwoods@chromium.org>
parent 3b579e36
...@@ -138,9 +138,9 @@ TString UniformHLSL::uniformsHeader(ShShaderOutput outputType, const ReferencedS ...@@ -138,9 +138,9 @@ TString UniformHLSL::uniformsHeader(ShShaderOutput outputType, const ReferencedS
{ {
const TStructure *structure = type.getStruct(); const TStructure *structure = type.getStruct();
// If this is a nameless struct, we need to use its full definition, rather than its (empty) name. // If this is a nameless struct, we need to use its full definition, rather than its (empty) name.
// TypeString() will invoke defineNameless in this case, but layout qualifiers will not be taken into // TypeString() will invoke defineNameless in this case; qualifier prefixes are unnecessary for
// account in this case. // nameless structs in ES, as nameless structs cannot be used anywhere that layout qualifiers are
// TODO: handle nameless structs with layout qualifiers. // permitted.
const TString &typeName = ((structure && !structure->name().empty()) ? const TString &typeName = ((structure && !structure->name().empty()) ?
QualifiedStructNameString(*structure, false, false) : TypeString(type)); QualifiedStructNameString(*structure, false, false) : TypeString(type));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment