CaptureReplay: Emit unused resources

In the final frame of Manhattan, resources are cleaned up, even if they are non-existent. This is allowed by the GLES spec. Compilation of the replay would fail, for instance: error: use of undeclared identifier 'gRenderbufferMap'; did you mean 'gFramebufferMap'? const GLuint glDeleteRenderbuffers_renderbuffersPacked_0[] = { gRenderbufferMap[0] }; ^~~~~~~~~~~~~~~~ This is because we are only declaring resources if they are used. Instead, go ahead and emit the resources, then circle back when filtering is implemented, allow that to optimize the replay. Bug: angleproject:4091 Bug: angleproject:4223 Change-Id: Ib48da0d9c3f4f2eca268646e7717a12126b1d85c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2066455Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>

CaptureReplay: Emit unused resources
b8ca4309 · Cody Northrop · Commit Bot · ce4918f1 · b8ca4309
Commit b8ca4309 authored Feb 20, 2020 by Cody Northrop Committed by Commit Bot Feb 21, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 5 deletions

FrameCapture.cpp src/libANGLE/FrameCapture.cpp +2 -5

No files found.
--- a/src/libANGLE/FrameCapture.cpp
+++ b/src/libANGLE/FrameCapture.cpp
@@ -807,9 +807,7 @@ void WriteCppReplayIndexFiles(const std::string &outDir,
    }
    for (ResourceIDType resourceType : AllEnums<ResourceIDType>())
    {
-        if (!hasResourceType[resourceType])
+        // TODO: Only emit resources needed by the frames (anglebug.com/4223)
-            continue;
        const char *name = GetResourceIDTypeName(resourceType);
        header << "extern ResourceMap g" << name << "Map;\n";
        source << "ResourceMap g" << name << "Map;\n";
@@ -875,8 +873,7 @@ void WriteCppReplayIndexFiles(const std::string &outDir,
    for (ResourceIDType resourceType : AllEnums<ResourceIDType>())
    {
-        if (!hasResourceType[resourceType])
+        // TODO: Only emit resources needed by the frames (anglebug.com/4223)
-            continue;
        const char *name = GetResourceIDTypeName(resourceType);
        header << "void Update" << name << "ID(GLuint id, GLsizei readBufferOffset);\n";