Clean up dead insertion of unmangled symbols

Unmangled names of built-ins are not inserted to the symbol table in a normal way, so the function to do that is not needed. BUG=angleproject:2267 TEST=compile ANGLE Change-Id: I68bae9a1f762ecc69ab31f04458a38c941b9d74c Reviewed-on: https://chromium-review.googlesource.com/922202Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Clean up dead insertion of unmangled symbols
b92f92a7 · Olli Etuaho · Commit Bot · b5db2b49 · b92f92a7
Commit b92f92a7 authored Feb 15, 2018 by Olli Etuaho Committed by Commit Bot Feb 15, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 15 deletions

SymbolTable.cpp src/compiler/translator/SymbolTable.cpp +3 -15

No files found.
--- a/src/compiler/translator/SymbolTable.cpp
+++ b/src/compiler/translator/SymbolTable.cpp
@@ -32,7 +32,7 @@ class TSymbolTable::TSymbolTableLevel
    bool insert(TSymbol *symbol);
    // Insert a function using its unmangled name as the key.
-    bool insertUnmangled(TFunction *function);
+    void insertUnmangled(TFunction *function);
    TSymbol *find(const ImmutableString &name) const;
@@ -65,9 +65,6 @@ class TSymbolTable::TSymbolTableBuiltInLevel
    bool insert(const TSymbol *symbol);
-    // Insert a function using its unmangled name as the key.
-    bool insertUnmangled(const TFunction *function);
    const TSymbol *find(const ImmutableString &name) const;
    void insertUnmangledBuiltInName(const char *name);
@@ -92,11 +89,9 @@ bool TSymbolTable::TSymbolTableLevel::insert(TSymbol *symbol)
    return result.second;
 }
-bool TSymbolTable::TSymbolTableLevel::insertUnmangled(TFunction *function)
+void TSymbolTable::TSymbolTableLevel::insertUnmangled(TFunction *function)
 {
-    // returning true means symbol was added to the table
+    level.insert(tLevelPair(function->name(), function));
-    tInsertResult result = level.insert(tLevelPair(function->name(), function));
-    return result.second;
 }
 TSymbol *TSymbolTable::TSymbolTableLevel::find(const ImmutableString &name) const
@@ -115,13 +110,6 @@ bool TSymbolTable::TSymbolTableBuiltInLevel::insert(const TSymbol *symbol)
    return result.second;
 }
-bool TSymbolTable::TSymbolTableBuiltInLevel::insertUnmangled(const TFunction *function)
-{
-    // returning true means symbol was added to the table
-    tInsertResult result = mLevel.insert(tLevelPair(function->name(), function));
-    return result.second;
-}
 const TSymbol *TSymbolTable::TSymbolTableBuiltInLevel::find(const ImmutableString &name) const
 {
    tLevel::const_iterator it = mLevel.find(name);