Skip to content

A
angle
Commit bacb8dfc by Kai Ninomiya Committed by Commit Bot
Options

Add TODOs for Apple DTK skips; update bug urls

Bug: angleproject:5360 Change-Id: Ibad5be256f08c893caebd6fa268668b966556d13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2544907Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent f197ebac
Showing with 29 additions and 26 deletions
src/tests/gl_tests/BPTCCompressedTextureTest.cpp
...@@ -273,6 +273,7 @@ TEST_P(BPTCCompressedTextureTestES3, CopyTexSubImage3DDisallowed) ...@@ -273,6 +273,7 @@ TEST_P(BPTCCompressedTextureTestES3, CopyTexSubImage3DDisallowed)
// Test uploading texture data from a PBO to a texture. // Test uploading texture data from a PBO to a texture.
TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImage) TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImage)
{ {
// TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal());
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_texture_compression_bptc")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_texture_compression_bptc"));
...@@ -326,6 +327,7 @@ TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImage) ...@@ -326,6 +327,7 @@ TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImage)
// Test uploading texture data from a PBO to a non-zero base texture. // Test uploading texture data from a PBO to a non-zero base texture.
TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImageNonZeroBase) TEST_P(BPTCCompressedTextureTestES3, PBOCompressedTexImageNonZeroBase)
{ {
// TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal());
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_texture_compression_bptc")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_texture_compression_bptc"));
......
src/tests/gl_tests/BuiltinVariableTest.cpp
...@@ -283,7 +283,7 @@ TEST_P(BuiltinVariableFragDepthClampingFloatRBOTest, Above0) ...@@ -283,7 +283,7 @@ TEST_P(BuiltinVariableFragDepthClampingFloatRBOTest, Above0)
// Test that gl_FragDepth is clamped below 1 // Test that gl_FragDepth is clamped below 1
TEST_P(BuiltinVariableFragDepthClampingFloatRBOTest, Below1) TEST_P(BuiltinVariableFragDepthClampingFloatRBOTest, Below1)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
CheckDepthWritten(1.0f, 42.0f); CheckDepthWritten(1.0f, 42.0f);
......
src/tests/gl_tests/CopyTexImageTest.cpp
...@@ -466,7 +466,7 @@ TEST_P(CopyTexImageTest, CopyTexSubImageToNonCubeCompleteDestination) ...@@ -466,7 +466,7 @@ TEST_P(CopyTexImageTest, CopyTexSubImageToNonCubeCompleteDestination)
// Deleting textures after copying to them. http://anglebug.com/4267 // Deleting textures after copying to them. http://anglebug.com/4267
TEST_P(CopyTexImageTest, DeleteAfterCopyingToTextures) TEST_P(CopyTexImageTest, DeleteAfterCopyingToTextures)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
GLTexture texture; GLTexture texture;
......
src/tests/gl_tests/GLSLTest.cpp
...@@ -826,7 +826,7 @@ TEST_P(GLSLTest_ES3, GLVertexIDIntegerTextureDrawArrays) ...@@ -826,7 +826,7 @@ TEST_P(GLSLTest_ES3, GLVertexIDIntegerTextureDrawArrays)
ANGLE_SKIP_TEST_IF(isSwiftshader()); ANGLE_SKIP_TEST_IF(isSwiftshader());
// http://anglebug.com/5232 // http://anglebug.com/5232
ANGLE_SKIP_TEST_IF(IsMetal()); ANGLE_SKIP_TEST_IF(IsMetal());
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
// Have to set a large point size because the window size is much larger than the texture // Have to set a large point size because the window size is much larger than the texture
constexpr char kVS[] = R"(#version 300 es constexpr char kVS[] = R"(#version 300 es
...@@ -1563,7 +1563,7 @@ TEST_P(GLSLTest, MaxVaryingVec3AndOneFloat) ...@@ -1563,7 +1563,7 @@ TEST_P(GLSLTest, MaxVaryingVec3AndOneFloat)
// Only fails on D3D9 because of packing limitations. // Only fails on D3D9 because of packing limitations.
TEST_P(GLSLTest, MaxVaryingVec3ArrayAndOneFloatArray) TEST_P(GLSLTest, MaxVaryingVec3ArrayAndOneFloatArray)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal());
GLint maxVaryings = 0; GLint maxVaryings = 0;
...@@ -1601,7 +1601,7 @@ TEST_P(GLSLTest, MaxVaryingVec2Arrays) ...@@ -1601,7 +1601,7 @@ TEST_P(GLSLTest, MaxVaryingVec2Arrays)
// (http://anglebug.com/1291) // (http://anglebug.com/1291)
ANGLE_SKIP_TEST_IF(IsOSX() && IsAMD() && IsOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsAMD() && IsOpenGL());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal());
GLint maxVaryings = 0; GLint maxVaryings = 0;
...@@ -5418,7 +5418,7 @@ TEST_P(GLSLTest, NestedStructsWithSamplersAsFunctionArg) ...@@ -5418,7 +5418,7 @@ TEST_P(GLSLTest, NestedStructsWithSamplersAsFunctionArg)
// Shader failed to compile on Nexus devices. http://anglebug.com/2114 // Shader failed to compile on Nexus devices. http://anglebug.com/2114
ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES()); ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
const char kFragmentShader[] = R"(precision mediump float; const char kFragmentShader[] = R"(precision mediump float;
...@@ -5524,7 +5524,7 @@ TEST_P(GLSLTest, NestedCompoundStructsWithSamplersAsFunctionArg) ...@@ -5524,7 +5524,7 @@ TEST_P(GLSLTest, NestedCompoundStructsWithSamplersAsFunctionArg)
// Shader failed to compile on Nexus devices. http://anglebug.com/2114 // Shader failed to compile on Nexus devices. http://anglebug.com/2114
ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES()); ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
const char kFragmentShader[] = R"(precision mediump float; const char kFragmentShader[] = R"(precision mediump float;
...@@ -5592,7 +5592,7 @@ TEST_P(GLSLTest, MoreNestedCompoundStructsWithSamplersAsFunctionArg) ...@@ -5592,7 +5592,7 @@ TEST_P(GLSLTest, MoreNestedCompoundStructsWithSamplersAsFunctionArg)
// Shader failed to compile on Nexus devices. http://anglebug.com/2114 // Shader failed to compile on Nexus devices. http://anglebug.com/2114
ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES()); ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsAdreno() && IsOpenGLES());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
const char kFragmentShader[] = R"(precision mediump float; const char kFragmentShader[] = R"(precision mediump float;
......
src/tests/gl_tests/MipmapTest.cpp
...@@ -609,6 +609,7 @@ TEST_P(MipmapTest, DISABLED_ThreeLevelsInitData) ...@@ -609,6 +609,7 @@ TEST_P(MipmapTest, DISABLED_ThreeLevelsInitData)
// conformance2/textures/misc/tex-mipmap-levels WebGL2 test. // conformance2/textures/misc/tex-mipmap-levels WebGL2 test.
TEST_P(MipmapTestES3, GenerateMipmapPartialLevels) TEST_P(MipmapTestES3, GenerateMipmapPartialLevels)
{ {
// TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
const std::vector<GLColor> kRedData(64, GLColor::red); const std::vector<GLColor> kRedData(64, GLColor::red);
...@@ -1670,7 +1671,7 @@ TEST_P(MipmapTestES3, GenerateMipmapBaseLevel) ...@@ -1670,7 +1671,7 @@ TEST_P(MipmapTestES3, GenerateMipmapBaseLevel)
// Observed incorrect rendering on AMD, sampling level 2 returns black. // Observed incorrect rendering on AMD, sampling level 2 returns black.
ANGLE_SKIP_TEST_IF(IsAMD() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsAMD() && IsDesktopOpenGL());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
glBindTexture(GL_TEXTURE_2D, mTexture); glBindTexture(GL_TEXTURE_2D, mTexture);
...@@ -1725,7 +1726,7 @@ TEST_P(MipmapTestES3, GenerateMipmapPreservesOutOfRangeMips) ...@@ -1725,7 +1726,7 @@ TEST_P(MipmapTestES3, GenerateMipmapPreservesOutOfRangeMips)
// http://anglebug.com/4786 // http://anglebug.com/4786
ANGLE_SKIP_TEST_IF(IsOpenGLES() && IsNVIDIAShield()); ANGLE_SKIP_TEST_IF(IsOpenGLES() && IsNVIDIAShield());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
constexpr GLint kTextureSize = 16; constexpr GLint kTextureSize = 16;
...@@ -1793,7 +1794,7 @@ TEST_P(MipmapTestES3, GenerateMipmapCubeBaseLevel) ...@@ -1793,7 +1794,7 @@ TEST_P(MipmapTestES3, GenerateMipmapCubeBaseLevel)
// Observed incorrect rendering on AMD, sampling level 2 returns black. // Observed incorrect rendering on AMD, sampling level 2 returns black.
ANGLE_SKIP_TEST_IF(IsAMD() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsAMD() && IsDesktopOpenGL());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
ASSERT_EQ(getWindowWidth(), getWindowHeight()); ASSERT_EQ(getWindowWidth(), getWindowHeight());
...@@ -1847,7 +1848,7 @@ TEST_P(MipmapTestES3, GenerateMipmapCubeBaseLevel) ...@@ -1847,7 +1848,7 @@ TEST_P(MipmapTestES3, GenerateMipmapCubeBaseLevel)
// the levelbase array, are left unchanged by this computation." // the levelbase array, are left unchanged by this computation."
TEST_P(MipmapTestES3, GenerateMipmapMaxLevel) TEST_P(MipmapTestES3, GenerateMipmapMaxLevel)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
glBindTexture(GL_TEXTURE_2D, mTexture); glBindTexture(GL_TEXTURE_2D, mTexture);
...@@ -1955,7 +1956,7 @@ TEST_P(MipmapTestES3, BaseLevelTextureBug) ...@@ -1955,7 +1956,7 @@ TEST_P(MipmapTestES3, BaseLevelTextureBug)
// Probably not Intel. // Probably not Intel.
ANGLE_SKIP_TEST_IF(IsOSX() && (IsNVIDIA() || IsIntel())); ANGLE_SKIP_TEST_IF(IsOSX() && (IsNVIDIA() || IsIntel()));
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
std::vector<GLColor> texDataRed(2u * 2u, GLColor::red); std::vector<GLColor> texDataRed(2u * 2u, GLColor::red);
......
src/tests/gl_tests/OcclusionQueriesTest.cpp
...@@ -394,7 +394,7 @@ TEST_P(OcclusionQueriesTest, MultiQueries) ...@@ -394,7 +394,7 @@ TEST_P(OcclusionQueriesTest, MultiQueries)
// http://anglebug.com/4925 // http://anglebug.com/4925
ANGLE_SKIP_TEST_IF(IsMetal() && IsNVIDIA()); ANGLE_SKIP_TEST_IF(IsMetal() && IsNVIDIA());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsMetal());
......
src/tests/gl_tests/TextureTest.cpp
...@@ -3619,7 +3619,7 @@ TEST_P(Texture2DBaseMaxTestES3, GenerateMipmapAfterRedefineAndRebase) ...@@ -3619,7 +3619,7 @@ TEST_P(Texture2DBaseMaxTestES3, GenerateMipmapAfterRedefineAndRebase)
// http://crbug.com/1100613 // http://crbug.com/1100613
ANGLE_SKIP_TEST_IF(IsNVIDIAShield()); ANGLE_SKIP_TEST_IF(IsNVIDIAShield());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
initTest(); initTest();
...@@ -6869,7 +6869,7 @@ TEST_P(Texture2DFloatTestES2, TextureHalfFloatSampleLegacyTest) ...@@ -6869,7 +6869,7 @@ TEST_P(Texture2DFloatTestES2, TextureHalfFloatSampleLegacyTest)
// Test linear sampling for ES3 32F formats // Test linear sampling for ES3 32F formats
TEST_P(Texture2DFloatTestES3, TextureFloatLinearTest) TEST_P(Texture2DFloatTestES3, TextureFloatLinearTest)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal())); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal()));
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float_linear")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float_linear"));
...@@ -6880,7 +6880,7 @@ TEST_P(Texture2DFloatTestES3, TextureFloatLinearTest) ...@@ -6880,7 +6880,7 @@ TEST_P(Texture2DFloatTestES3, TextureFloatLinearTest)
// Test linear sampling for ES2 32F formats // Test linear sampling for ES2 32F formats
TEST_P(Texture2DFloatTestES2, TextureFloatLinearTest) TEST_P(Texture2DFloatTestES2, TextureFloatLinearTest)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal())); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal()));
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float_linear")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float_linear"));
...@@ -6908,7 +6908,7 @@ TEST_P(Texture2DFloatTestES2, TextureHalfFloatLinearTest) ...@@ -6908,7 +6908,7 @@ TEST_P(Texture2DFloatTestES2, TextureHalfFloatLinearTest)
// Test linear sampling for legacy GLES 2.0 32F formats in ES3 // Test linear sampling for legacy GLES 2.0 32F formats in ES3
TEST_P(Texture2DFloatTestES3, TextureFloatLinearLegacyTest) TEST_P(Texture2DFloatTestES3, TextureFloatLinearLegacyTest)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal())); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal()));
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float"));
...@@ -6928,7 +6928,7 @@ TEST_P(Texture2DFloatTestES3, TextureFloatLinearLegacyTest) ...@@ -6928,7 +6928,7 @@ TEST_P(Texture2DFloatTestES3, TextureFloatLinearLegacyTest)
// Test linear sampling for legacy GLES 2.0 32F formats in ES2 // Test linear sampling for legacy GLES 2.0 32F formats in ES2
TEST_P(Texture2DFloatTestES2, TextureFloatLinearLegacyTest) TEST_P(Texture2DFloatTestES2, TextureFloatLinearLegacyTest)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal())); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && (IsDesktopOpenGL() || IsMetal()));
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_OES_texture_float"));
......
src/tests/gl_tests/TimerQueriesTest.cpp
...@@ -86,7 +86,7 @@ TEST_P(TimerQueriesTest, ProcAddresses) ...@@ -86,7 +86,7 @@ TEST_P(TimerQueriesTest, ProcAddresses)
// Tests the time elapsed query // Tests the time elapsed query
TEST_P(TimerQueriesTest, TimeElapsed) TEST_P(TimerQueriesTest, TimeElapsed)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_disjoint_timer_query")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_disjoint_timer_query"));
...@@ -281,7 +281,7 @@ TEST_P(TimerQueriesTest, TimeElapsedMulticontextTest) ...@@ -281,7 +281,7 @@ TEST_P(TimerQueriesTest, TimeElapsedMulticontextTest)
// http://anglebug.com/1541 // http://anglebug.com/1541
ANGLE_SKIP_TEST_IF(IsAMD() && IsOpenGL()); ANGLE_SKIP_TEST_IF(IsAMD() && IsOpenGL());
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_disjoint_timer_query")); ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_EXT_disjoint_timer_query"));
......
src/tests/gl_tests/TransformFeedbackTest.cpp
...@@ -877,7 +877,7 @@ TEST_P(TransformFeedbackTest, TwoUnreferencedInFragShader) ...@@ -877,7 +877,7 @@ TEST_P(TransformFeedbackTest, TwoUnreferencedInFragShader)
{ {
// TODO(anglebug.com/4533) This fails after the upgrade to the 26.20.100.7870 driver. // TODO(anglebug.com/4533) This fails after the upgrade to the 26.20.100.7870 driver.
ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan()); ANGLE_SKIP_TEST_IF(IsWindows() && IsIntel() && IsVulkan());
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
// TODO(jmadill): With points and rasterizer discard? // TODO(jmadill): With points and rasterizer discard?
...@@ -1528,7 +1528,7 @@ TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVarying) ...@@ -1528,7 +1528,7 @@ TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVarying)
// nonexistent varying is prefixed with "gl_". // nonexistent varying is prefixed with "gl_".
TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVaryingWithGLPrefix) TEST_P(TransformFeedbackTest, NonExistentTransformFeedbackVaryingWithGLPrefix)
{ {
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
std::vector<std::string> tfVaryings; std::vector<std::string> tfVaryings;
...@@ -1631,7 +1631,7 @@ TEST_P(TransformFeedbackTest, NoTransformFeedbackVaryingsInUse) ...@@ -1631,7 +1631,7 @@ TEST_P(TransformFeedbackTest, NoTransformFeedbackVaryingsInUse)
// Test that you can pause transform feedback without drawing first. // Test that you can pause transform feedback without drawing first.
TEST_P(TransformFeedbackTest, SwitchProgramBeforeDraw) TEST_P(TransformFeedbackTest, SwitchProgramBeforeDraw)
{ {
// TODO(crbug.com/1132295): Failing on ARM-based Apple DTKs. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
std::vector<std::string> tfVaryings; std::vector<std::string> tfVaryings;
......
src/tests/gl_tests/WebGLCompatibilityTest.cpp
...@@ -2724,7 +2724,7 @@ void main() { ...@@ -2724,7 +2724,7 @@ void main() {
// Based on the WebGL test conformance/textures/misc/texture-copying-feedback-loops.html // Based on the WebGL test conformance/textures/misc/texture-copying-feedback-loops.html
TEST_P(WebGLCompatibilityTest, TextureCopyingFeedbackLoops) TEST_P(WebGLCompatibilityTest, TextureCopyingFeedbackLoops)
{ {
// TODO(crbug.com/1132295): Failing on Apple DTK. // TODO(anglebug.com/5360): Failing on ARM-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
GLTexture texture; GLTexture texture;
...@@ -2795,7 +2795,7 @@ TEST_P(WebGL2CompatibilityTest, CopyMip1ToMip0) ...@@ -2795,7 +2795,7 @@ TEST_P(WebGL2CompatibilityTest, CopyMip1ToMip0)
// http://anglebug.com/4805 // http://anglebug.com/4805
ANGLE_SKIP_TEST_IF(IsOpenGL() && IsIntel() && (IsWindows() || IsOSX())); ANGLE_SKIP_TEST_IF(IsOpenGL() && IsIntel() && (IsWindows() || IsOSX()));
// TODO(crbug.com/1132295): Failing on ARM64-based Apple DTKs. // TODO(anglebug.com/5360): Failing on ARM64-based Apple DTKs.
ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL()); ANGLE_SKIP_TEST_IF(IsOSX() && IsARM64() && IsDesktopOpenGL());
GLFramebuffer framebuffer; GLFramebuffer framebuffer;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment