Skip to content

A
angle
Commit bc82fb14 by Jonah Ryan-Davis Committed by Commit Bot
Options

Suppress failing end2end tests for ASAN builds

GLSLTest_ES31.StructArraySample and ComputeShaderTest.DispatchComputeIndirect both hit stack-buffer-overflow errors with ASAN enabled, using the vulkan backend. Right now ASAN is only tested on Mac, so these are only hit when Mac is using swiftshader-vulkan. Bug: 1029378 Change-Id: Ie590f73c29be44f683fd47fe4da139e1b5f96289 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943408Reviewed-by: 's avatarJonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
parent 82219d28
Showing with 8 additions and 0 deletions
src/tests/gl_tests/ComputeShaderTest.cpp
...@@ -637,6 +637,10 @@ TEST_P(ComputeShaderTest, DispatchComputeIndirect) ...@@ -637,6 +637,10 @@ TEST_P(ComputeShaderTest, DispatchComputeIndirect)
// Flaky crash on teardown, see http://anglebug.com/3349 // Flaky crash on teardown, see http://anglebug.com/3349
ANGLE_SKIP_TEST_IF(IsD3D11() && IsIntel() && IsWindows()); ANGLE_SKIP_TEST_IF(IsD3D11() && IsIntel() && IsWindows());
// ASAN error on vulkan backend; ASAN tests only enabled on Mac Swangle
// (http://crbug.com/1029378)
ANGLE_SKIP_TEST_IF(IsOSX() && isSwiftshader());
GLTexture texture; GLTexture texture;
GLFramebuffer framebuffer; GLFramebuffer framebuffer;
const char kCSSource[] = R"(#version 310 es const char kCSSource[] = R"(#version 310 es
......
src/tests/gl_tests/GLSLTest.cpp
...@@ -3142,6 +3142,10 @@ TEST_P(GLSLTest_ES31, ArraysOfArraysSampler) ...@@ -3142,6 +3142,10 @@ TEST_P(GLSLTest_ES31, ArraysOfArraysSampler)
// Test that structs containing arrays of samplers work as expected. // Test that structs containing arrays of samplers work as expected.
TEST_P(GLSLTest_ES31, StructArraySampler) TEST_P(GLSLTest_ES31, StructArraySampler)
{ {
// ASAN error on vulkan backend; ASAN tests only enabled on Mac Swangle
// (http://crbug.com/1029378)
ANGLE_SKIP_TEST_IF(IsOSX() && isSwiftshader());
constexpr char kFS[] = constexpr char kFS[] =
"#version 310 es\n" "#version 310 es\n"
"precision mediump float;\n" "precision mediump float;\n"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment