Enable more warnings on GCC and clang

build/common.gypi

@@ -22,7 +22,6 @@
             '-Wextra',
             '-Wformat=2',
             '-Winit-self',
-            '-Wno-sign-compare',
             '-Wno-unused-function',
             '-Wno-unused-parameter',
             '-Wno-unknown-pragmas',
@@ -30,9 +29,7 @@
             '-Wpointer-arith',
             '-Wundef',
             '-Wwrite-strings',
-            '-Wno-reorder',
             '-Wno-format-nonliteral',
-            '-Wno-deprecated-register',
         ],
     },
     'target_defaults':

src/compiler/translator/CallDAG.cpp

@@ -18,9 +18,9 @@ class CallDAG::CallDAGCreator : public TIntermTraverser
   public:
     CallDAGCreator(TInfoSinkBase *info)
         : TIntermTraverser(true, false, true),
+          mCreationInfo(info),
           mCurrentFunction(nullptr),
-          mCurrentIndex(0),
-          mCreationInfo(info)
+          mCurrentIndex(0)
     {
     }
 

src/compiler/translator/InitializeVariables.h

@@ -26,8 +26,8 @@ class InitializeVariables : public TIntermTraverser
     typedef TVector<InitVariableInfo> InitVariableInfoList;
 
     InitializeVariables(const InitVariableInfoList &vars)
-        : mCodeInserted(false),
-          mVariables(vars)
+        : mVariables(vars),
+          mCodeInserted(false)
     {
     }
 

src/compiler/translator/ParseContext.h

@@ -39,8 +39,10 @@ class TParseContext : angle::NonCopyable
                   bool debugShaderPrecisionSupported)
         : intermediate(interm),
           symbolTable(symt),
+          mDeferredSingleDeclarationErrorCheck(false),
           mShaderType(type),
           mShaderSpec(spec),
+          mShaderVersion(100),
           mTreeRoot(nullptr),
           mLoopNestingLevel(0),
           mStructNestingLevel(0),
@@ -52,11 +54,9 @@ class TParseContext : angle::NonCopyable
           mDefaultMatrixPacking(EmpColumnMajor),
           mDefaultBlockStorage(EbsShared),
           mDiagnostics(is),
-          mShaderVersion(100),
           mDirectiveHandler(ext, mDiagnostics, mShaderVersion, debugShaderPrecisionSupported),
           mPreprocessor(&mDiagnostics, &mDirectiveHandler),
           mScanner(nullptr),
-          mDeferredSingleDeclarationErrorCheck(false),
           mUsesFragData(false),
           mUsesFragColor(false)
     {

src/libANGLE/Caps.cpp

@@ -111,9 +111,9 @@ Extensions::Extensions()
       textureCompressionDXT3(false),
       textureCompressionDXT5(false),
       depthTextures(false),
+      textureStorage(false),
       textureNPOT(false),
       drawBuffers(false),
-      textureStorage(false),
       textureFilterAnisotropic(false),
       maxTextureAnisotropy(false),
       occlusionQueryBoolean(false),

src/libANGLE/Program.cpp

@@ -144,10 +144,10 @@ LinkedVarying::LinkedVarying(const std::string &name, GLenum type, GLsizei size,
 Program::Program(rx::ProgramImpl *impl, ResourceManager *manager, GLuint handle)
     : mProgram(impl),
       mValidated(false),
-      mTransformFeedbackVaryings(),
-      mTransformFeedbackBufferMode(GL_NONE),
       mFragmentShader(nullptr),
       mVertexShader(nullptr),
+      mTransformFeedbackVaryings(),
+      mTransformFeedbackBufferMode(GL_NONE),
       mLinked(false),
       mDeleteStatus(false),
       mRefCount(0),

src/libANGLE/Shader.cpp

@@ -25,12 +25,12 @@ namespace gl
 
 Shader::Shader(ResourceManager *manager, rx::ShaderImpl *impl, GLenum type, GLuint handle)
     : mShader(impl),
-      mType(type),
       mHandle(handle),
-      mResourceManager(manager),
+      mType(type),
       mRefCount(0),
       mDeleteStatus(false),
-      mCompiled(false)
+      mCompiled(false),
+      mResourceManager(manager)
 {
     ASSERT(impl);
 }

src/libANGLE/formatutils.cpp

@@ -228,13 +228,13 @@ InternalFormat::InternalFormat()
       stencilBits(0),
       pixelBytes(0),
       componentCount(0),
+      compressed(false),
       compressedBlockWidth(0),
       compressedBlockHeight(0),
       format(GL_NONE),
       type(GL_NONE),
       componentType(GL_NONE),
       colorEncoding(GL_NONE),
-      compressed(false),
       textureSupport(NeverSupported),
       renderSupport(NeverSupported),
       filterSupport(NeverSupported)