M92: Vulkan: Free DynamicBuffer buffers after dip in allocation size

In a pattern like this: - allocate 100 bytes - allocate 200 bytes - allocate 50 bytes - allocate 100000000 bytes - allocate 100 bytes - allocate 200 bytes - allocate 50 bytes The DynamicBuffer class switches to making 100MB allocations even if that allocation was a one-off. A small future allocation would then tie up 100MB in memory for future allocations. Another 100MB is also left tied up in the free list. With this change, if an allocation is made that's less than a quarter of the DynamicBuffer's current allocation size, it's taken as a sign that the previous large allocation was a one-off and the size is moved back to the DynamicBuffer's original initial size. Bug: b/187757166 Bug: chromium:1224952 Change-Id: Icb69bfa3196daa1ee8e6c38ef9513730f9afacfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2991915Reviewed-by: Jamie Madill <jmadill@chromium.org>

M92: Vulkan: Free DynamicBuffer buffers after dip in allocation size
bce42eda · Shahbaz Youssefi · 6bbd095a · bce42eda
Commit bce42eda authored Jun 17, 2021 by Shahbaz Youssefi
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

vk_helpers.cpp src/libANGLE/renderer/vulkan/vk_helpers.cpp +4 -3

No files found.
--- a/src/libANGLE/renderer/vulkan/vk_helpers.cpp
+++ b/src/libANGLE/renderer/vulkan/vk_helpers.cpp
@@ -2053,11 +2053,12 @@ angle::Result DynamicBuffer::allocateWithAlignment(ContextVk *contextVk,
            ASSERT(!mBuffer);
        }
-        if (sizeToAllocate > mSize)
+        const size_t sizeIgnoringHistory = std::max(mInitialSize, sizeToAllocate);
+        if (sizeToAllocate > mSize || sizeIgnoringHistory < mSize / 4)
        {
-            mSize = std::max(mInitialSize, sizeToAllocate);
+            mSize = sizeIgnoringHistory;
-            // Clear the free list since the free buffers are now too small.
+            // Clear the free list since the free buffers are now either too small or too big.
            ReleaseBufferListToRenderer(contextVk->getRenderer(), &mBufferFreeList);
        }