Trace Tests: Fix Win/x86 crash.

A missing KHRONOS_APIENTRY annotation was causing a crash due to stack corruption in Win/x86 only. Bug: angleproject:4845 Bug: chromium:1111764 Change-Id: I60b30ce8bc409c71d223eaedd74dc0c1ae034f7a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331739 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Trace Tests: Fix Win/x86 crash.
bd7cef28 · Jamie Madill · Commit Bot · be774187 · bd7cef28
Commit bd7cef28 authored Jul 31, 2020 by Jamie Madill Committed by Commit Bot Jul 31, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

TracePerfTest.cpp src/tests/perf_tests/TracePerfTest.cpp +2 -1

No files found.
--- a/src/tests/perf_tests/TracePerfTest.cpp
+++ b/src/tests/perf_tests/TracePerfTest.cpp
@@ -102,7 +102,8 @@ class TracePerfTest : public ANGLERenderTest, public ::testing::WithParamInterfa
 class TracePerfTest;
 TracePerfTest *gCurrentTracePerfTest = nullptr;

-void BindFramebufferProc(GLenum target, GLuint framebuffer)
+// Don't forget to include KHRONOS_APIENTRY in override methods. Neccessary on Win/x86.
+void KHRONOS_APIENTRY BindFramebufferProc(GLenum target, GLuint framebuffer)
 {
    glBindFramebuffer(target, framebuffer);
    gCurrentTracePerfTest->onReplayFramebufferChange(target, framebuffer);