Commit bd966253 by Shahbaz Youssefi Committed by Commit Bot

Increase MAX_UNIFORM_BUFFER_BINDINGS to 72

This is the minimum Vulkan limit. Bug: angleproject:5212 Change-Id: I627a1446434c7abc2f53525cb71cb40a4927461c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2491937Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
parent b0db7cca
...@@ -41,7 +41,9 @@ enum ...@@ -41,7 +41,9 @@ enum
IMPLEMENTATION_MAX_COMBINED_SHADER_UNIFORM_BUFFERS = 36, IMPLEMENTATION_MAX_COMBINED_SHADER_UNIFORM_BUFFERS = 36,
// GL_EXT_geometry_shader increases the minimum value of GL_MAX_UNIFORM_BUFFER_BINDINGS to 48. // GL_EXT_geometry_shader increases the minimum value of GL_MAX_UNIFORM_BUFFER_BINDINGS to 48.
IMPLEMENTATION_MAX_UNIFORM_BUFFER_BINDINGS = 48, // Vulkan's minimum value for maxDescriptorSetUniformBuffers is 72 so allow exposing up to that
// many.
IMPLEMENTATION_MAX_UNIFORM_BUFFER_BINDINGS = 72,
// Transform feedback limits set to the minimum required by the spec. // Transform feedback limits set to the minimum required by the spec.
IMPLEMENTATION_MAX_TRANSFORM_FEEDBACK_INTERLEAVED_COMPONENTS = 128, IMPLEMENTATION_MAX_TRANSFORM_FEEDBACK_INTERLEAVED_COMPONENTS = 128,
......
...@@ -987,11 +987,6 @@ angle::Result ProgramExecutableVk::updateBuffersDescriptorSet( ...@@ -987,11 +987,6 @@ angle::Result ProgramExecutableVk::updateBuffersDescriptorSet(
descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER); descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER);
const bool isStorageBuffer = descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER; const bool isStorageBuffer = descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER;
static_assert(
gl::IMPLEMENTATION_MAX_SHADER_STORAGE_BUFFER_BINDINGS >=
gl::IMPLEMENTATION_MAX_UNIFORM_BUFFER_BINDINGS,
"The descriptor arrays here would have inadequate size for uniform buffer objects");
VkDescriptorSet descriptorSet = VkDescriptorSet descriptorSet =
mDescriptorSets[ToUnderlying(DescriptorSetIndex::ShaderResource)]; mDescriptorSets[ToUnderlying(DescriptorSetIndex::ShaderResource)];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment