Skip to content

A
angle
Commit c07bd2f2 by Jamie Madill Committed by Commit Bot
Options

Ensure trace test failures are unexpected.

This will make the names of the failures show up in Milo. Bug: angleproject:5310 Change-Id: I64e1f5ffff04ec70a44f8f3d0c339da2bca6b216 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2520539Reviewed-by: 's avatarCody Northrop <cnorthrop@google.com> Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
parent 3942e801
Showing with 2 additions and 0 deletions
src/tests/restricted_traces/restricted_trace_gold_tests.py
...@@ -396,6 +396,8 @@ def main(): ...@@ -396,6 +396,8 @@ def main():
expected_result = SKIP if result == SKIP else PASS expected_result = SKIP if result == SKIP else PASS
result_tests[test] = {'expected': expected_result, 'actual': result} result_tests[test] = {'expected': expected_result, 'actual': result}
if result == FAIL:
result_tests[test]['is_unexpected'] = True
if len(artifacts) > 0: if len(artifacts) > 0:
result_tests[test]['artifacts'] = artifacts result_tests[test]['artifacts'] = artifacts
results['num_failures_by_type'][result] += 1 results['num_failures_by_type'][result] += 1
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment