ProgramD3D: only broadcast when the GL_EXT_draw_buffers is enabled

The behavior is undefined in GL ES when multiple attachments are used with gl_FragColor but WebGL clarifies that: - If the extension is enabled, broadcast happens - If the extension isn't enabled, only the first attachment is written BUG=angleproject:2048 Change-Id: I6d85ba91df77d42fb8863a03f1faa006cd7817bf Reviewed-on: https://chromium-review.googlesource.com/523809Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

ProgramD3D: only broadcast when the GL_EXT_draw_buffers is enabled
c084de14 · Corentin Wallez · Commit Bot · 0492d447 · c084de14 · c084de14
Commit c084de14 authored Jun 05, 2017 by Corentin Wallez Committed by Commit Bot Jun 12, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

ProgramD3D.cpp src/libANGLE/renderer/d3d/ProgramD3D.cpp +2 -1

WebGLCompatibilityTest.cpp src/tests/gl_tests/WebGLCompatibilityTest.cpp +4 -2

No files found.
--- a/src/libANGLE/renderer/d3d/ProgramD3D.cpp
+++ b/src/libANGLE/renderer/d3d/ProgramD3D.cpp
@@ -331,7 +331,8 @@ int ProgramD3DMetadata::getRendererMajorShaderModel() const
 bool ProgramD3DMetadata::usesBroadcast(const gl::ContextState &data) const
 {
-    return (mFragmentShader->usesFragColor() && data.getClientMajorVersion() < 3);
+    return (mFragmentShader->usesFragColor() && mFragmentShader->usesMultipleRenderTargets() &&
+            data.getClientMajorVersion() < 3);
 }
 bool ProgramD3DMetadata::usesFragDepth() const

--- a/src/tests/gl_tests/WebGLCompatibilityTest.cpp
+++ b/src/tests/gl_tests/WebGLCompatibilityTest.cpp
@@ -2610,9 +2610,11 @@ TEST_P(WebGL2CompatibilityTest, VertexShaderAttributeTypeMissmatch)
 // Tests the WebGL removal of undefined behavior when attachments aren't written to.
 TEST_P(WebGLCompatibilityTest, DrawBuffers)
 {
-    if (IsD3D9() || IsD3D11())
+    // TODO(cwallez) AMD incorrectly write black to the first render target when the HLSL pixel
+    // shader doesn't write anything to the ouput.
+    if (IsD3D11() && IsAMD())
    {
-        std::cout << "Test skipped on " << GetParam() << std::endl;
+        std::cout << "Test skipped on AMD " << GetParam() << std::endl;
        return;
    }