Fix two issues with GLES2 devices

* make sure maxColorAttachments is greater than 0 * Do not sync read buffer if maxDrawBuffers is 0 Bug: chromium:1167731 Change-Id: Icd0fb5e65ec6ffdc0d6f6325ccd1207958922254 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2733268Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>

Fix two issues with GLES2 devices
c0ed204d · Peng Huang · Commit Bot · a272a8ac · c0ed204d · c0ed204d
Commit c0ed204d authored Mar 03, 2021 by Peng Huang Committed by Commit Bot Mar 08, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

Framebuffer.cpp src/libANGLE/Framebuffer.cpp +4 -1

renderergl_utils.cpp src/libANGLE/renderer/gl/renderergl_utils.cpp +6 -1

No files found.
--- a/src/libANGLE/Framebuffer.cpp
+++ b/src/libANGLE/Framebuffer.cpp
@@ -705,7 +705,10 @@ Framebuffer::Framebuffer(const Caps &caps,
    {
        mDirtyColorAttachmentBindings.emplace_back(this, DIRTY_BIT_COLOR_ATTACHMENT_0 + colorIndex);
    }
-    mDirtyBits.set(DIRTY_BIT_READ_BUFFER);
+    if (caps.maxDrawBuffers > 1)
+    {
+        mDirtyBits.set(DIRTY_BIT_READ_BUFFER);
+    }
 }

 Framebuffer::Framebuffer(const Context *context, egl::Surface *surface, egl::Surface *readSurface)

--- a/src/libANGLE/renderer/gl/renderergl_utils.cpp
+++ b/src/libANGLE/renderer/gl/renderergl_utils.cpp
@@ -638,11 +638,16 @@ void GenerateCaps(const FunctionsGL *functions,

    if (functions->isAtLeastGL(gl::Version(3, 0)) ||
        functions->hasGLExtension("GL_EXT_framebuffer_object") ||
-        functions->isAtLeastGLES(gl::Version(2, 0)))
+        functions->isAtLeastGLES(gl::Version(3, 0)))
    {
        caps->maxRenderbufferSize = QuerySingleGLInt(functions, GL_MAX_RENDERBUFFER_SIZE);
        caps->maxColorAttachments = QuerySingleGLInt(functions, GL_MAX_COLOR_ATTACHMENTS);
    }
+    else if (functions->isAtLeastGLES(gl::Version(2, 0)))
+    {
+        caps->maxRenderbufferSize = QuerySingleGLInt(functions, GL_MAX_RENDERBUFFER_SIZE);
+        caps->maxColorAttachments = 1;
+    }
    else
    {
        // Can't support ES2 without framebuffers and renderbuffers